Skip to contentSkip to conversation

common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL

PATCH New Lars Povlsen 3 participants 3 messages Oct 23, 2018 – Nov 9, 2018

lore
Share & tools
lore

Lars Povlsen

author
#0 lore raw

PATCH v2 1/1 common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL

common/common_fit.c is including <spl.h>, but not actually using it. The inclusion will cuase compile error on platforms using CONFIG_OF_SEPARATE and not SPL.

Signed-off-by Lars Povlsen <[email protected]>
---
 common/common_fit.c | 1 -
 1 file changed, 1 deletion(-)
common/common_fit.c +0 -1
index 577b352..a35c7e9 100644
@@ -8,7 +8,6 @@
 #include <errno.h>
 #include <image.h>
 #include <linux/libfdt.h>
-#include <spl.h>
 
 ulong fdt_getprop_u32(const void *fdt, int node, const char *prop)
 {
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL

Quoted 14 lines · Lars Povlsen

common/common_fit.c is including <spl.h>, but not actually using it. The inclusion will cuase compile error on platforms using CONFIG_OF_SEPARATE and not SPL.

Signed-off-by Lars Povlsen <[email protected]>
---
  common/common_fit.c | 1 -
  1 file changed, 1 deletion(-)
common/common_fit.c +0 -0
index 577b352..a35c7e9 100644

common/common_fit.c line 13

Quoted 7 lines
common/common_fit.c +0 -1
@@ -8,7 +8,6 @@
  #include <errno.h>
  #include <image.h>
  #include <linux/libfdt.h>
-#include <spl.h>
 
  ulong fdt_getprop_u32(const void *fdt, int node, const char *prop)
  {
Reviewed-by Jean-Jacques Hiblot <[email protected]>
#2 lore raw

PATCH v2 1/1 common: Compile error with CONFIG_MULTI_DTB_FIT and not SPL

In reply to Lars Povlsen
Quoted 6 lines · Lars Povlsen

common/common_fit.c is including <spl.h>, but not actually using it. The inclusion will cuase compile error on platforms using CONFIG_OF_SEPARATE and not SPL.

Signed-off-by Lars Povlsen <[email protected]>
Reviewed-by Jean-Jacques Hiblot <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181109/03112611/attachment.sig>