soc_camera and device-tree

Hi Guennadi,

I'm slowly converting all of my drivers to device-tree. In the process, I met ... soc_camera.

I converted mt9m111.c and pxa_camera.c, but now I need the linking soc_camera. And I don't have a clear idea on how it should be done.

I was thinking of having soc_camera_pdrv_probe() changed, to handle device-tree. What bothers me a bit is that amongst the needed data for me are the bus_id and a soc_camera_subdev_desc. I was thinking that this could be expressed in device-tree like :

	soc_camera {
		icd = <&mt9m111>;
        	ici = <&pxa_camera>;
        }
...
	pxai2c1: i2c@40301680 {
		status = "okay";

		mt9m111@5d {
			compatible = "micron,mt9m111";
			reg = <0x5d>;
		};
	};

	pxa_camera {
		compatible = "mrvl,pxa_camera";
		mclk_10khz = <5000>;
		flags = <0xc9>;
	};

Do you have any hints and advices to help me ?

Cheers.

Signature · 1 line

Robert

Hi Robert,

Quoted 5 lines · Robert Jarzmik

Hi Guennadi,

I'm slowly converting all of my drivers to device-tree. In the process, I met ... soc_camera.

Quoted 2 lines

I converted mt9m111.c and pxa_camera.c, but now I need the linking soc_camera. And I don't have a clear idea on how it should be done.

Have a look at this thread

http://thread.gmane.org/gmane.linux.ports.sh.devel/34412/focus=36244

Hi Guennadi,

I'm slowly converting all of my drivers to device-tree. In the process, I met ... soc_camera.

I converted mt9m111.c and pxa_camera.c, but now I need the linking soc_camera. And I don't have a clear idea on how it should be done.

I was thinking of having soc_camera_pdrv_probe() changed, to handle device-tree. What bothers me a bit is that amongst the needed data for me are the bus_id and a soc_camera_subdev_desc. I was thinking that this could be expressed in device-tree like :

Quoted 9 lines · Guennadi Liakhovetski

Hi Robert,

Quoted 5 lines · Robert Jarzmik

Hi Guennadi,

I'm slowly converting all of my drivers to device-tree. In the process, I met ... soc_camera.

Quoted 6 lines

Quoted 2 lines

I converted mt9m111.c and pxa_camera.c, but now I need the linking soc_camera. And I don't have a clear idea on how it should be done.

Have a look at this thread

http://thread.gmane.org/gmane.linux.ports.sh.devel/34412/focus=36244

Ah excellent, job's done before working, just as I like it :)

Just a couple of remarks :
- in Ben's serie, there is/are call(s) to v4l2_of_get_next_endpoint(). This was recently replaced with of_graph_get_next_endpoint(). Same story for v4l2_of_get_remote_port() replaced by of_graph_get_remote_port().

See commit "[media] of: move graph helpers from drivers/media/v4l2-core to drivers/of", commit id fd9fdb7.

- the clock "mclk" topic
There will be cases where this SoC clock won't be available in the common clock framework, ie. not in drivers/clk. For example the PXA architecture is not yet ported to the commmon clk framework (it's in the staging). So we should be carefull to not assume common clock framework is available.

- the testing coverage
For the next spin I'd like to be joined to the list of reviewers/testers. As I'm testing it for another couple of host/icd, that will grow up the test base.

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Robert,

Quoted 7 lines · Robert Jarzmik

Hi Guennadi,

I'm slowly converting all of my drivers to device-tree. In the process, I met ... soc_camera.

I converted mt9m111.c and pxa_camera.c, but now I need the linking soc_camera. And I don't have a clear idea on how it should be done.