expression: examine constness of __builtin_offsetof at evaluation only

RFC PATCH Superseded Nicolai Stange 1 participant 1 message Jul 22, 2015 Sparse checker

Share & tools

Nicolai Stange

author

2015-07-22 23:21 UTC #0 lore raw

RFC PATCH 9/13 expression: examine constness of __builtin_offsetof at evaluation only

Currently, the determination of a __builtin_offsetof() expressions' constness flags is done in two steps:
- Several flags are speculatively set at expression parsing time
- and possibly cleared again at evaluation if the member expression includes a non-const array index like in __builtin_offsetof(struct A, a.b[non_const_foo])

For consistency with other expression types' evaluation, defer the determination of a __builtin_offsetof() expression's constness to evaluation time, too.

Furthermore, carry an array index expression's constness flags through the implicit cast to size_t type.

Signed-off-by Nicolai Stange <[email protected]>

---
 evaluate.c                      | 15 +++++++++------
 expression.c                    |  3 ---
 validation/constexpr-offsetof.c | 21 +++++++++++++++++++++
 3 files changed, 30 insertions(+), 9 deletions(-)
 create mode 100644 validation/constexpr-offsetof.c

evaluate.c +9 -6

index a65cc0c..c115e64 100644
@@ -3002,7 +3002,7 @@ static struct symbol *evaluate_offsetof(struct expression *expr)
 		}
 		ctype = field;
 		expr->type = EXPR_VALUE;
-		expr->flags = expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
+		expr->flags |= expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
 		expr->value = offset;
 		expr->taint = 0;
 		expr->ctype = size_t_ctype;

@@ -3021,20 +3021,24 @@ static struct symbol *evaluate_offsetof(struct expression *expr)
 		if (!expr->index) {
 			expr->type = EXPR_VALUE;
 			expr->flags
-				= expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
+				|= expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
 			expr->value = 0;
 			expr->taint = 0;
 			expr->ctype = size_t_ctype;
 		} else {
 			struct expression *idx = expr->index, *m;
 			struct symbol *i_type = evaluate_expression(idx);
+			unsigned old_idx_flags;
 			int i_class = classify_type(i_type, &i_type);
+
 			if (!is_int(i_class)) {
 				expression_error(expr, "non-integer index");
 				return NULL;
 			}
 			unrestrict(idx, i_class, &i_type);
+			old_idx_flags = idx->flags;
 			idx = cast_to(idx, size_t_ctype);
+			idx->flags |= expr_flags_decay_consts(old_idx_flags);
 			m = alloc_const_expression(expr->pos,
 						   bits_to_bytes(ctype->bit_size));
 			m->ctype = size_t_ctype;

@@ -3044,8 +3048,8 @@ static struct symbol *evaluate_offsetof(struct expression *expr)
 			expr->right = m;
 			expr->op = '*';
 			expr->ctype = size_t_ctype;
-			expr->flags = m->flags & idx->flags &
-				expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
+			expr->flags |=
+				expr_flags_decay_consts(m->flags & idx->flags);
 		}
 	}
 	if (e) {

@@ -3056,8 +3060,7 @@ static struct symbol *evaluate_offsetof(struct expression *expr)
 		if (!evaluate_expression(e))
 			return NULL;
 		expr->type = EXPR_BINOP;
-		expr->flags = e->flags & copy->flags &
-			expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
+		expr->flags = expr_flags_decay_consts(e->flags & copy->flags);
 		expr->op = '+';
 		expr->ctype = size_t_ctype;
 		expr->left = copy;

expression.c +0 -3

index 19786e8..a4b6fa2 100644
@@ -200,7 +200,6 @@ static struct token *builtin_offsetof_expr(struct token *token,
 			return expect(token, ')', "at end of __builtin_offset");
 		case SPECIAL_DEREFERENCE:
 			e = alloc_expression(token->pos, EXPR_OFFSETOF);
-			e->flags = expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
 			e->op = '[';
 			*p = e;
 			p = &e->down;

@@ -208,7 +207,6 @@ static struct token *builtin_offsetof_expr(struct token *token,
 		case '.':
 			token = token->next;
 			e = alloc_expression(token->pos, EXPR_OFFSETOF);
-			e->flags = expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
 			e->op = '.';
 			if (token_type(token) != TOKEN_IDENT) {
 				sparse_error(token->pos, "Expected member name");

@@ -220,7 +218,6 @@ static struct token *builtin_offsetof_expr(struct token *token,
 		case '[':
 			token = token->next;
 			e = alloc_expression(token->pos, EXPR_OFFSETOF);
-			e->flags = expr_set_flag_mask(EXPR_FLAG_INT_CONST_EXPR);
 			e->op = '[';
 			token = parse_expression(token, &e->index);
 			token = expect(token, ']',

validation/constexpr-offsetof.c new file +21 -0

new file mode 100644
index 0000000..d1697b0
@@ -0,0 +1,21 @@
+struct A {
+	int a[1];
+	int b;
+};
+
+extern int c;
+
+static int o[] = {
+	[__builtin_offsetof(struct A, b)] = 0,		// OK
+	[__builtin_offsetof(struct A, a[0])] = 0,	// OK
+	[__builtin_offsetof(struct A, a[0*0])] = 0,	// OK
+	[__builtin_offsetof(struct A, a[c])] = 0	// KO
+};
+
+/*
+ * check-name: __builtin_offsetof() constness verification
+ *
+ * check-error-start
+constexpr-offsetof.c:12:39: error: bad constant expression
+ * check-error-end
+ */

Signature · 1 line

2.4.5