Skip to contentSkip to conversation

ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

PATCH Applied Kuninori Morimoto 4 participants 9 messages Jul 17, 2014 – Jul 23, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rsnd: add missing src/dst_addr_width for DMAEngine

From: Kuninori Morimoto <[email protected]>

Renesas new DMAEngine driver requests src/dst_addr_width

---

Quoted 1 line
Quoted 1 line

Laurent

Could you please check and give your Ack to this patch?

 sound/soc/sh/rcar/core.c |    2 ++
 1 file changed, 2 insertions(+)
sound/soc/sh/rcar/core.c +2 -0
index 907d480..c48d999 100644
@@ -338,6 +338,8 @@ int rsnd_dma_init(struct rsnd_priv *priv, struct rsnd_dma *dma,
 	cfg.direction	= is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
 	cfg.src_addr	= rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
 	cfg.dst_addr	= rsnd_gen_dma_addr(priv, mod_to,   is_play, 0);
+	cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
+	cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
 
 	dev_dbg(dev, "dma : %s %pad -> %pad\n",
 		dma_name, &cfg.src_addr, &cfg.dst_addr);
Signature · 1 line
1.7.9.5
#1 lore raw

Hi Morimoto-san,

Quoted 10 lines · On Wednesday 16 July 2014 23:18:44 Kuninori Morimoto wrote:

From: Kuninori Morimoto <[email protected]>

Renesas new DMAEngine driver requests src/dst_addr_width

---

Quoted 1 line
Quoted 1 line

Laurent

Could you please check and give your Ack to this patch?

What tree is the patch based on ? It doesn't apply on Takashi's latest master branch. I need a bit of context to review it.

Quoted 16 lines
 sound/soc/sh/rcar/core.c |    2 ++
 1 file changed, 2 insertions(+)
sound/soc/sh/rcar/core.c +2 -0
index 907d480..c48d999 100644
@@ -338,6 +338,8 @@ int rsnd_dma_init(struct rsnd_priv *priv, struct
 rsnd_dma *dma, cfg.direction	= is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
 	cfg.src_addr	= rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
 	cfg.dst_addr	= rsnd_gen_dma_addr(priv, mod_to,   is_play, 0);
+	cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
+	cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
 
 	dev_dbg(dev, "dma : %s %pad -> %pad\n",
 		dma_name, &cfg.src_addr, &cfg.dst_addr);
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw

Hi Laurent

Quoted 7 lines
Quoted 7 lines

From: Kuninori Morimoto <[email protected]>

Renesas new DMAEngine driver requests src/dst_addr_width

---

Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line

Laurent

Could you please check and give your Ack to this patch?

What tree is the patch based on ? It doesn't apply on Takashi's latest master branch. I need a bit of context to review it.

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git :: topic/rcar

or Gerrt's driver tree

#3 lore raw

Hi Morimoto-san,

Quoted 13 lines · On Monday 21 July 2014 16:55:41 Kuninori Morimoto wrote:

Hi Laurent

Quoted 11 lines
Quoted 10 lines

From: Kuninori Morimoto <[email protected]>

Renesas new DMAEngine driver requests src/dst_addr_width

---

Quoted 1 line
Quoted 1 line

Laurent

Could you please check and give your Ack to this patch?

Quoted 7 lines
Quoted 2 lines

What tree is the patch based on ? It doesn't apply on Takashi's latest master branch. I need a bit of context to review it.

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git ::
topic/rcar

or Gerrt's driver tree

Of course :-)

I've tried to understand the driver and couldn't even find out which DMA controller was used :-/ I suspect it's the audio peri-peri DMAC, but I haven't been able to confirm that from the source code. If the assumption is true the patch looks OK to me, but if you need a formal Acked-by then I'll need you to guide me through the driver I'm afraid.

Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw

Hi Laurent

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

What tree is the patch based on ? It doesn't apply on Takashi's latest master branch. I need a bit of context to review it.

(snip)

Quoted 5 lines

I've tried to understand the driver and couldn't even find out which DMA controller was used :-/ I suspect it's the audio peri-peri DMAC, but I haven't been able to confirm that from the source code. If the assumption is true the patch looks OK to me, but if you need a formal Acked-by then I'll need you to guide me through the driver I'm afraid.

Ahh I'm sorry about this confusion.
It uses audio peri-peri DMAC, and, your rcar-dmac (as audio DMAC) The platform side is not upstreamed yet.
(Because it depends on rcar-dmac)

But, I posted RFC audio DMAC support patches which was based on Ben's DMAC before.

    http://www.spinics.net/lists/linux-sh/msg32949.html

I can re-post this patch if all DMAC was ready

Best regards
---
Kuninori Morimoto

Acked-by on v1 1/1
#7 lore raw
In reply to Kuninori Morimoto

Hi Morimoto-san,

Thank you for the patch.

Quoted 5 lines · On Wednesday 16 July 2014 23:18:44 Kuninori Morimoto wrote:

From: Kuninori Morimoto <[email protected]>

Renesas new DMAEngine driver requests src/dst_addr_width

Quoted 22 lines

---

Quoted 1 line
Quoted 1 line

Laurent

Could you please check and give your Ack to this patch?

 sound/soc/sh/rcar/core.c |    2 ++
 1 file changed, 2 insertions(+)
sound/soc/sh/rcar/core.c +2 -0
index 907d480..c48d999 100644
@@ -338,6 +338,8 @@ int rsnd_dma_init(struct rsnd_priv *priv, struct
 rsnd_dma *dma, cfg.direction	= is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
 	cfg.src_addr	= rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
 	cfg.dst_addr	= rsnd_gen_dma_addr(priv, mod_to,   is_play, 0);
+	cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
+	cfg.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
 
 	dev_dbg(dev, "dma : %s %pad -> %pad\n",
 		dma_name, &cfg.src_addr, &cfg.dst_addr);
Signature · 3 lines
Regards,

Laurent Pinchart
#5 lore raw
In reply to Kuninori Morimoto

Hi Morimoto-san,

Quoted 18 lines · On Monday 21 July 2014 19:34:36 Kuninori Morimoto wrote:

Hi Laurent

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

What tree is the patch based on ? It doesn't apply on Takashi's latest master branch. I need a bit of context to review it.

(snip)

Quoted 5 lines

I've tried to understand the driver and couldn't even find out which DMA controller was used :-/ I suspect it's the audio peri-peri DMAC, but I haven't been able to confirm that from the source code. If the assumption is true the patch looks OK to me, but if you need a formal Acked-by then I'll need you to guide me through the driver I'm afraid.

Ahh I'm sorry about this confusion.
It uses audio peri-peri DMAC, and, your rcar-dmac (as audio DMAC) The platform side is not upstreamed yet.
(Because it depends on rcar-dmac)

Quoted 6 lines

But, I posted RFC audio DMAC support patches which was based on Ben's DMAC before.

    http://www.spinics.net/lists/linux-sh/msg32949.html

I can re-post this patch if all DMAC was ready

No need to, that was enough. Thank you. I've acked the patch.

By the way, I'd like to test cyclic transfers with the rcar-dmac driver. Is there an easy (or at least not too difficult) way to do so with your audio driver ?

Signature · 3 lines
Regards,

Laurent Pinchart
#6 lore raw
In reply to Laurent Pinchart

Hi Laurent

Quoted 7 lines
Quoted 1 line

I can re-post this patch if all DMAC was ready

No need to, that was enough. Thank you. I've acked the patch.

By the way, I'd like to test cyclic transfers with the rcar-dmac driver. Is there an easy (or at least not too difficult) way to do so with your audio driver ?

Thank you for your help.
Yes, me too :)

I re-try your v2 DMAC driver with sound driver today. Then, I will post platform side patches to ML