Skip to contentSkip to conversation

macb broken on HiFive Unleashed

DISCUSSION Andreas Schwab 5 participants 11 messages Mar 8, 2021 – Mar 19, 2021

Subsystems (3)
Networking Network drivers RISC-V
lore
Share & tools
lore

Andreas Schwab

author
#0 lore raw

One of the changes to the macb driver between 5.10 and 5.11 has broken the SiFive HiFive Unleashed. These are the last messages before the system hangs:

[   12.468674] libphy: Fixed MDIO Bus: probed
[   12.746518] macb 10090000.ethernet: Registered clk switch 'sifive-gemgxl-mgmt'
[   12.753119] macb 10090000.ethernet: GEM doesn't support hardware ptp.
[   12.760178] libphy: MACB_mii_bus: probed
[   12.881792] MACsec IEEE 802.1AE
[   12.944426] macb 10090000.ethernet eth0: Cadence GEM rev 0x10070109 at 0x10090000 irq 16 (70:b3:d5:92:f1:07)

Andreas.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#1 lore raw

Hi Andreas,

Quoted 6 lines · Andreas Schwab

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

One of the changes to the macb driver between 5.10 and 5.11 has broken the SiFive HiFive Unleashed. These are the last messages before the system hangs:

Quoted 7 lines
[   12.468674] libphy: Fixed MDIO Bus: probed
[   12.746518] macb 10090000.ethernet: Registered clk switch 'sifive-gemgxl-mgmt'
[   12.753119] macb 10090000.ethernet: GEM doesn't support hardware ptp.
[   12.760178] libphy: MACB_mii_bus: probed
[   12.881792] MACsec IEEE 802.1AE
[   12.944426] macb 10090000.ethernet eth0: Cadence GEM rev 0x10070109 at 0x10090000 irq 16 (70:b3:d5:92:f1:07)

I don't have a SiFive HiFive Unleashed to investigate this. Can you check if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:

git log --oneline v5.10..v5.11 -- drivers/net/ethernet/cadence/ 1d0d561ad1d7 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag 1d608d2e0d51 Revert "macb: support the two tx descriptors on at91rm9200" 700d566e8171 net: macb: add support for sama7g5 emac interface ec771de654e4 net: macb: add support for sama7g5 gem interface f4de93f03ed8 net: macb: unprepare clocks in case of failure 38493da4e6a8 net: macb: add function to disable all macb clocks daafa1d33cc9 net: macb: add capability to not set the clock rate edac63861db7 net: macb: add userio bits as platform configuration 9e6cad531c9d net: macb: Fix passing zero to 'PTR_ERR' 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method e4e143e26ce8 net: macb: add support for high speed interface

Thank you,
Claudiu Beznea

Quoted 7 lines

Andreas.

--
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#2 lore raw

Hi,

Quoted 20 lines · On Tue, Mar 09, 2021 at 08:55:10AM +0000, [email protected] wrote:

Hi Andreas,

Quoted 6 lines · Andreas Schwab

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

One of the changes to the macb driver between 5.10 and 5.11 has broken the SiFive HiFive Unleashed. These are the last messages before the system hangs:

Quoted 7 lines
[   12.468674] libphy: Fixed MDIO Bus: probed
[   12.746518] macb 10090000.ethernet: Registered clk switch 'sifive-gemgxl-mgmt'
[   12.753119] macb 10090000.ethernet: GEM doesn't support hardware ptp.
[   12.760178] libphy: MACB_mii_bus: probed
[   12.881792] MACsec IEEE 802.1AE
[   12.944426] macb 10090000.ethernet eth0: Cadence GEM rev 0x10070109 at 0x10090000 irq 16 (70:b3:d5:92:f1:07)

I don't have a SiFive HiFive Unleashed to investigate this. Can you check if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:

Quoted 12 lines

git log --oneline v5.10..v5.11 -- drivers/net/ethernet/cadence/ 1d0d561ad1d7 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag 1d608d2e0d51 Revert "macb: support the two tx descriptors on at91rm9200" 700d566e8171 net: macb: add support for sama7g5 emac interface ec771de654e4 net: macb: add support for sama7g5 gem interface f4de93f03ed8 net: macb: unprepare clocks in case of failure 38493da4e6a8 net: macb: add function to disable all macb clocks daafa1d33cc9 net: macb: add capability to not set the clock rate edac63861db7 net: macb: add userio bits as platform configuration 9e6cad531c9d net: macb: Fix passing zero to 'PTR_ERR' 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method e4e143e26ce8 net: macb: add support for high speed interface

In addition, it's worth mentioning that the driver has multiple rx/tx/irq functions depending on the platforms or chip variants, and that based on this it should be easy to further reduce this list.

Just my two cents,
Willy

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

author
#3 lore raw
In reply to [email protected]
Quoted 15 lines · On Mär 09 2021, [email protected] wrote:

I don't have a SiFive HiFive Unleashed to investigate this. Can you check if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:

git log --oneline v5.10..v5.11 -- drivers/net/ethernet/cadence/ 1d0d561ad1d7 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag 1d608d2e0d51 Revert "macb: support the two tx descriptors on at91rm9200" 700d566e8171 net: macb: add support for sama7g5 emac interface ec771de654e4 net: macb: add support for sama7g5 gem interface f4de93f03ed8 net: macb: unprepare clocks in case of failure 38493da4e6a8 net: macb: add function to disable all macb clocks daafa1d33cc9 net: macb: add capability to not set the clock rate edac63861db7 net: macb: add userio bits as platform configuration 9e6cad531c9d net: macb: Fix passing zero to 'PTR_ERR' 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method e4e143e26ce8 net: macb: add support for high speed interface

Unfortunately, that didn't help.

Andreas.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#4 lore raw

Hi Andreas

Quoted 17 lines · Andreas Schwab
Quoted 15 lines · On Mär 09 2021, [email protected] wrote:

I don't have a SiFive HiFive Unleashed to investigate this. Can you check if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:

git log --oneline v5.10..v5.11 -- drivers/net/ethernet/cadence/ 1d0d561ad1d7 net: macb: Correct usage of MACB_CAPS_CLK_HW_CHG flag 1d608d2e0d51 Revert "macb: support the two tx descriptors on at91rm9200" 700d566e8171 net: macb: add support for sama7g5 emac interface ec771de654e4 net: macb: add support for sama7g5 gem interface f4de93f03ed8 net: macb: unprepare clocks in case of failure 38493da4e6a8 net: macb: add function to disable all macb clocks daafa1d33cc9 net: macb: add capability to not set the clock rate edac63861db7 net: macb: add userio bits as platform configuration 9e6cad531c9d net: macb: Fix passing zero to 'PTR_ERR' 0012eeb370f8 net: macb: fix NULL dereference due to no pcs_config method e4e143e26ce8 net: macb: add support for high speed interface

Quoted 1 line

Unfortunately, that didn't help.

Sorry, for being late to test this, but I just compiled and booted 5.11.6 and ethernet works just fine for me:
https://esmil.dk/hfu-5.11.6.txt

As you can see I haven't updated OpenSBI or u-boot in a while, don't know if that makes a difference. You can fetch the config is used here:
https://esmil.dk/hfu-5.11.6.config

/Emil

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

author
#5 lore raw
Quoted 1 line · Emil Renner Berthing

As you can see I haven't updated OpenSBI or u-boot in a while

Does it also work if you use the u-boot SPL instead of FSBL?

Andreas.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
author
#6 lore raw
In reply to [email protected]

It turned out to be a broken clock driver.

Andreas.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#8 lore raw

HI Andreas:

Quoted 11 lines · Yixun Lan

HI Andreas:

Quoted 3 lines · Andreas Schwab

It turned out to be a broken clock driver.

what's the exact root cause? and any solution?
seems I face the same issue, upgrade kernel to 5.11, then eth0 fail to bring up

oh, sorry for the noise, just saw you already commented in another thread..

https://lkml.kernel.org/r/[email protected]

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

author
#9 lore raw
In reply to Yixun Lan
Quoted 1 line · Yixun Lan

what's the exact root cause? and any solution?

Try reverting the five commits starting with
732374a0b440d9a79c8412f318a25cd37ba6f4e2.

Andreas.

Signature · 8 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#10 lore raw

HI Andreas, Zong:

Quoted 8 lines · Andreas Schwab
Quoted 1 line · Yixun Lan

what's the exact root cause? and any solution?

Try reverting the five commits starting with
732374a0b440d9a79c8412f318a25cd37ba6f4e2.

I confirm reverting those five patches make the ethernet work again tested with kernel version 5.11.7

Yixun Lan

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv