Skip to contentSkip to conversation

usb: dwc2: gadget: Fix Remote Wakeup interrupt bit clearing

DISCUSSION Felipe Balbi 1 participant 1 message Jan 14, 2019 USB

lore
Share & tools
lore
#0 lore raw

Hi,

Quoted 20 lines · Minas Harutyunyan

Hi Greg, Filipe,

Quoted 17 lines · Minas Harutyunyan

To clear GINTSTS2_WKUP_ALERT_INT bit in GINTSTS2 register require to write 1. This bit is implemented as "Write to clear".

Fixes 187c5298a122 ("usb: dwc2: gadget: Add handler for WkupAlert

interrupt")

---
  drivers/usb/dwc2/gadget.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/dwc2/gadget.c +0 -0
index 68ad75a7460d..55ef3cc2701b 100644
@@ -261,7 +261,7 @@ static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg)
 
Quoted 12 lines

drivers/usb/dwc2/gadget.c static void dwc2_gadget_wkup_alert_handler(struct dwc2_hsotg *hsotg) · line 267

Quoted 8 lines
drivers/usb/dwc2/gadget.c +1 -1
  	if (gintsts2 & GINTSTS2_WKUP_ALERT_INT) {
  		dev_dbg(hsotg->dev, "%s: Wkup_Alert_Int\n", __func__);
-		dwc2_clear_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
+		dwc2_set_bit(hsotg, GINTSTS2, GINTSTS2_WKUP_ALERT_INT);
  		dwc2_set_bit(hsotg, DCTL, DCTL_RMTWKUPSIG);
  	}
  }

Sorry for last minute fix of this stupid bug.
Please get this commit together with "usb: dwc2: gadget: Fix WkupAlert interrupt handler."

And where is that?