recv.2: Mention SOCK_SEQPACKET in MSG_TRUNC flag description

unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles MSG_TRUNC. This has been the case since the support for this flag was implemented in the latter; the sequential-packet socket type seems to have been left out from the description by an oversight.

Signed-off-by Vladislav Ivanishin<[email protected]>

---
  man2/recv.2 | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

man2/recv.2 +2 -2

index d492976c4..c5f1a9d70 100644
@@ -226,7 +226,8 @@ subsequent receive call will return the same data.
  For raw
  .RB ( AF_PACKET ),
  Internet datagram (since Linux 2.4.27/2.6.8),
-netlink (since Linux 2.6.22), and UNIX datagram
+netlink (since Linux 2.6.22),
+and UNIX datagram as well as sequenced-packet
  .\" commit 9f6f9af7694ede6314bed281eec74d588ba9474f
  (since Linux 3.4) sockets:
  return the real length of the packet or datagram,
-- 2.37.3

Hi Vladislav,

Quoted 5 lines · Vladislav Ivanishin

unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles MSG_TRUNC. This has been the case since the support for this flag was implemented in the latter; the sequential-packet socket type seems to have been left out from the description by an oversight.

Signed-off-by Vladislav Ivanishin<[email protected]>

Could you please point to the relevant kernel commits, or quote the relevant lines of code, in the commit message?

Thanks,

Alex

unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles MSG_TRUNC. This has been the case since the handling was added in 9f6f9af7694ede6314bed281eec74d588ba9474f; see net/unix/af_unix.c:

static int unix_seqpacket_recvmsg([...])

{
        [...]
	return unix_dgram_recvmsg(iocb, sock, msg, size, flags);
}

The sequential-packet socket type seems to have been left out from the description by an oversight.

Signed-off-by Vladislav Ivanishin <[email protected]>

---

Hi Alex,

Quoted 9 lines · Alejandro Colomar

Hi Vladislav,

Quoted 5 lines · Vladislav Ivanishin

unix_seqpacket_recvmsg() calls unix_dgram_recvmsg() which handles MSG_TRUNC. This has been the case since the support for this flag was implemented in the latter; the sequential-packet socket type seems to have been left out from the description by an oversight.

Signed-off-by Vladislav Ivanishin<[email protected]>

Quoted 6 lines

Could you please point to the relevant kernel commits, or quote the relevant lines of code, in the commit message?

Thanks,

Alex

Sure, here's an updated version.

Vlad

 man2/recv.2 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

man2/recv.2 +2 -1

index 5298a2745..81cd1957c 100644
@@ -226,7 +226,8 @@ subsequent receive call will return the same data.
 For raw
 .RB ( AF_PACKET ),
 Internet datagram (since Linux 2.4.27/2.6.8),
-netlink (since Linux 2.6.22), and UNIX datagram
+netlink (since Linux 2.6.22),
+and UNIX datagram as well as sequenced-packet
 .\" commit 9f6f9af7694ede6314bed281eec74d588ba9474f
 (since Linux 3.4) sockets:
 return the real length of the packet or datagram,

Thanks! I CCd those involved in the referred commit. I'll give them a week or so to have a look.

Could you please ping me again in a week or so?

Quoted 2 lines · Alejandro Colomar

Thanks! I CCd those involved in the referred commit. I'll give them a week or so to have a look.

Great, thank you!

Quoted 1 line

Could you please ping me again in a week or so?

No problem, will do.

Hi Alex; ping!

Quoted 9 lines · Vladislav Ivanishin

Quoted 2 lines · Alejandro Colomar

Thanks! I CCd those involved in the referred commit. I'll give them a week or so to have a look.

Great, thank you!

Quoted 1 line

Could you please ping me again in a week or so?

No problem, will do.

Ping (there haven't been any objections to the current version of the patch at https://lore.kernel.org/linux-man/[email protected]/).

Quoted 1 line · Vladislav Ivanishin

Hi Alex; ping!

Quoted 11 lines · Vladislav Ivanishin

Quoted 9 lines · Alejandro Colomar

Quoted 2 lines

Thanks! I CCd those involved in the referred commit. I'll give them a week or so to have a look.

Great, thank you!

Quoted 1 line

Could you please ping me again in a week or so?

No problem, will do.