usb: dwc3: gadget: Don't skip updating remaining data

Quoted 23 lines · Felipe Balbi

Hi,

Thinh Nguyen <[email protected]> writes:

<snip>

Quoted 17 lines

Quoted 2 lines

These patches will not fix the issue.

What do you think of this fix?

drivers/usb/dwc3/gadget.c +0 -0

index f452ab708ffc..338f7ab8a8b4 100644
@@ -2277,8 +2277,10 @@ static int
 dwc3_gadget_ep_reclaim_completed_trb(struct dwc3_ep *dep,
         * with one TRB pending in the ring. We need to manually clear

HWO bit
* from that TRB.
*/

drivers/usb/dwc3/gadget.c +1 -2

-       if ((req->zero || req->unaligned) && (trb->ctrl & DWC3_TRB_CTRL_HWO)) {
-               trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
+       if ((req->zero || req->unaligned) && !chain) {

Quoted 9 lines

drivers/usb/dwc3/gadget.c

Quoted 5 lines

drivers/usb/dwc3/gadget.c +3 -0

+               if (trb->ctrl & DWC3_TRB_CTRL_HWO)
+                       trb->ctrl &= ~DWC3_TRB_CTRL_HWO;
+
                return 1;
        }

This is a rathher minimal fix. I like it. So this together with the one I wrote for the TRB type, right? Can you send this one as a proper patch and add the correct Cc stable and Fixes tags?

Yes. Can you create an official patch for that TRB type issue you found?