Skip to contentSkip to conversation

fixups for Raspberry Pi 5 revision D

DISCUSSION Rasmus Villemoes 2 participants 2 messages May 14 – May 15 Stable branch

lore
Share & tools
lore
#0 lore raw

Hi Greg,

Please consider adding the commits

aeb078cebc40d ("arm64: dts: broadcom: bcm2712-d-rpi-5-b: add fixes for pinctrl/pinctrl_aon") 18d4a06e10051 ("arm64: dts: broadcom: bcm2712-d-rpi-5-b: update uart10 interrupt")

to the stable trees. Without the first, a Raspberry Pi 5 revision D simply fails to boot, ending rather quickly with a

 Kernel panic - not syncing: Asynchronous SError Interrupt
 CPU: 2 UID: 0 PID: 1 Comm: swapper/0 Tainted: G   M                6.18.29 #1 NONE 
 Tainted: [M]=MACHINE_CHECK
 Hardware name: Raspberry Pi 5 Model B Rev 1.1 (DT)
 Call trace:
  show_stack+0x18/0x24 (C)
  dump_stack_lvl+0x60/0x80
  dump_stack+0x18/0x24
  vpanic+0xec/0x2d0
  abort+0x0/0x4
  nmi_panic+0x64/0x70
  arm64_serror_panic+0x70/0x7c
  do_serror+0x20/0x6c
  el1h_64_error_handler+0x38/0x60
  el1h_64_error+0x6c/0x70
  brcmstb_pull_config_set+0x64/0x128 (P)
  brcmstb_pinconf_set+0x64/0xd8
  pinconf_apply_setting+0xb8/0x13c
  pinctrl_commit_state+0x11c/0x260
  pinctrl_select_state+0x1c/0x30
  pinctrl_bind_pins+0x14c/0x160
  really_probe+0x54/0x2bc
  __driver_probe_device+0x78/0x120
  driver_probe_device+0x3c/0x178
  __driver_attach+0x90/0x184
  bus_for_each_dev+0x7c/0xe0
  driver_attach+0x24/0x3c
  bus_add_driver+0xe4/0x20c
  driver_register+0x68/0x130
  __platform_driver_register+0x20/0x2c
  brcmuart_init+0x38/0x5c
  do_one_initcall+0x60/0x1d4
  kernel_init_freeable+0x284/0x300
  kernel_init+0x28/0x13c
  ret_from_fork+0x10/0x20

since the pinctrl register layout is slightly different on that revision.

For both, a suitable Fixes tag would have been

Fixes 44839e2ac8ec5 ("arm64: dts: broadcom: Add DT for D-step version of BCM2712")

i.e. this goes back to 6.14, so I suppose that means it is eligible for 6.18.y and 7.0.y. I have tested by applying them on top of v6.18.29.

Thanks,
Rasmus

#1 lore raw
Quoted 9 lines · Rasmus Villemoes

Hi Greg,

Please consider adding the commits

aeb078cebc40d ("arm64: dts: broadcom: bcm2712-d-rpi-5-b: add fixes for pinctrl/pinctrl_aon") 18d4a06e10051 ("arm64: dts: broadcom: bcm2712-d-rpi-5-b: update uart10 interrupt")

to the stable trees. Without the first, a Raspberry Pi 5 revision D simply fails to boot, ending rather quickly with a

Both now queued up,t hanks.

greg k-h