Skip to contentSkip to conversation

spi-bcm2835 depends GPIOLIB

PATCH Applied Yoshinori Sato 2 participants 3 messages May 3, 2015 – May 7, 2015 SPI

lore
Share & tools
lore
#0 lore raw

I got following error on CONFIG_GPIOLIB=n.

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error: dereferencing pointer to incomplete type 'struct gpio_chip'

  return !strcmp(chip->label, data);
                     ^
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:9: error: implicit declaration of function 'gpiochip_find' [-Werror=implicit-function-declaration]
  chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
         ^
drivers/spi/spi-bcm2835.c:382:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
       ^

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:357:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^

drivers/spi/Kconfig +1 -0
index 198f96b..d5ed2a0 100644
@@ -77,6 +77,7 @@ config SPI_ATMEL
 
 config SPI_BCM2835
 	tristate "BCM2835 SPI controller"
+	depends on GPIOLIB
 	depends on ARCH_BCM2835 || COMPILE_TEST
 	help
 	  This selects a driver for the Broadcom BCM2835 SPI master.
Signature · 2 lines
Yoshinori Sato
<[email protected]>
maintainer Applied
#1 lore raw
Quoted 1 line · Yoshinori Sato

I got following error on CONFIG_GPIOLIB=n.

Applied, thanks, but please use subject lines reflecting the style for the subsystem.

#2 lore raw

At Mon, 4 May 2015 13:00:46 +0100,

Quoted 6 lines · Mark Brown
Quoted 1 line · Yoshinori Sato

I got following error on CONFIG_GPIOLIB=n.

Applied, thanks, but please use subject lines reflecting the style for the subsystem.

Oh. I'm sorry.
Thanks applied.

Signature · 6 lines
Yoshinori Sato
<[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html