mtdoops cleanup

Use memcpy instead of open coding a copy loop.

---
 drivers/mtd/mtdoops.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

index f8af627..20eaf29 100644
@@ -286,7 +286,6 @@ mtdoops_console_write(struct console *co, const char *s, unsigned int count)
 {
 	struct mtdoops_context *cxt = co->data;
 	struct mtd_info *mtd = cxt->mtd;
-	int i;
 
 	if (!oops_in_progress) {
 		mtdoops_console_sync();

@@ -305,10 +304,8 @@ mtdoops_console_write(struct console *co, const char *s, unsigned int count)
 	if ((count + cxt->writecount) > OOPS_PAGE_SIZE)
 		count = OOPS_PAGE_SIZE - cxt->writecount;
 
-	for (i = 0; i < count; i++, s++)
-		*((char *)(cxt->oops_buf) + cxt->writecount + i) = *s;
-
-	cxt->writecount = cxt->writecount + count;
+	memcpy(cxt->oops_buf + cxt->writecount, s, count);
+	cxt->writecount += count;
 }
 
 static int __init mtdoops_console_setup(struct console *co, char *options)

1.5.3.4

-- 
Bye, Peter Korsgaard

Comments?

Peter> Use memcpy instead of open coding a copy loop. Peter> Signed-off-by: Peter Korsgaard <[email protected]> Peter> ---

 Peter>  drivers/mtd/mtdoops.c |    7 ++-----

Peter> 1 files changed, 2 insertions(+), 5 deletions(-)

Peter> diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
Peter> index f8af627..20eaf29 100644
Peter> --- a/drivers/mtd/mtdoops.c
Peter> +++ b/drivers/mtd/mtdoops.c
Peter> @@ -286,7 +286,6 @@ mtdoops_console_write(struct console *co, const char *s, unsigned int count)

 Peter>  {
 Peter>  	struct mtdoops_context *cxt = co->data;
 Peter>  	struct mtd_info *mtd = cxt->mtd;

Peter> - int i;

Peter> if (!oops_in_progress) {
Peter> mtdoops_console_sync();
Peter> @@ -305,10 +304,8 @@ mtdoops_console_write(struct console *co, const char *s, unsigned int count)
Peter> if ((count + cxt->writecount) > OOPS_PAGE_SIZE)
Peter> count = OOPS_PAGE_SIZE - cxt->writecount;

Peter> - for (i = 0; i < count; i++, s++)
Peter> - *((char *)(cxt->oops_buf) + cxt->writecount + i) = *s;
Peter> -
Peter> - cxt->writecount = cxt->writecount + count;
Peter> + memcpy(cxt->oops_buf + cxt->writecount, s, count);
Peter> + cxt->writecount += count;
Peter> }

Peter> static int __init mtdoops_console_setup(struct console *co, char *options) Peter> --
Peter> 1.5.3.4

Peter> --
Peter> Bye, Peter Korsgaard

Peter> ______________________________________________________ Peter> Linux MTD discussion mailing list
Peter> http://lists.infradead.org/mailman/listinfo/linux-mtd/

Bye, Peter Korsgaard

David appears busy right now. It is not unusual if he ignores patches for weeks, then merges a dozen or more out of the blue.

Jörn

Joern's library part 13:
http://www.chip-architect.com/