Skip to contentSkip to conversation

printk: ignore consoles without write() callback

PATCH In review John Ogness 5 participants 10 messages Feb 16, 2023 – May 23, 2025 Printk

lore
Share & tools
lore

John Ogness

author maintainer
#0 lore raw

PATCH 1/1 printk: ignore consoles without write() callback

The ttynull driver does not provide an implementation for the write() callback. This leads to a NULL pointer dereference in the related printing kthread, which assumes it can call that callback.

Do not create kthreads for consoles that do not implement the write() callback. Also, for pr_flush(), ignore consoles that do not implement write() or write_atomic() since there is no way those consoles can flush their output.

Fixes 8782b1ef4125 ("printk: move console printing to kthreads")

---
This is only a problem for the PREEMPT_RT tree. Mainline does not have this problem.

 kernel/printk/printk.c | 6 ++++++
 1 file changed, 6 insertions(+)
kernel/printk/printk.c +6 -0
index 7f27cfee283e..752afe88b5b4 100644
@@ -2343,6 +2343,10 @@ static int printk_kthread_func(void *data)
 /* Must be called within console_lock(). */
 static void start_printk_kthread(struct console *con)
 {
+	/* No need to start a printing thread if the console cannot print. */
+	if (!con->write)
+		return;
+
 	con->thread = kthread_run(printk_kthread_func, con,
 				  "pr/%s%d", con->name, con->index);
 	if (IS_ERR(con->thread)) {
@@ -3737,6 +3741,8 @@ bool pr_flush(int timeout_ms, bool reset_on_progress)
 		for_each_console(con) {
 			if (!(con->flags & CON_ENABLED))
 				continue;
+			if (!con->write && !con->write_atomic)
+				continue;
 			printk_seq = read_console_seq(con);
 			if (printk_seq < seq)
 				diff += seq - printk_seq;
Signature · 1 line
2.30.2
#1 lore raw
Quoted 2 lines · John Ogness

This is only a problem for the PREEMPT_RT tree. Mainline does not have this problem.

Is this 5.15 and less or current dev RT and less?

Sebastian

author maintainer
#2 lore raw
Quoted 4 lines · Sebastian Siewior
Quoted 2 lines

This is only a problem for the PREEMPT_RT tree. Mainline does not have this problem.

Is this 5.15 and less or current dev RT and less?

5.10-rt is also affected. The changes for 5.10-rt are the same, but the patch does not apply as-is. I will reply with a patch for 5.10-rt.

5.4-rt is not affected.

John Ogness

author maintainer
#3 lore raw

PATCH 1/1 printk: ignore consoles without write() callback

The ttynull driver does not provide an implementation for the write() callback. This leads to a NULL pointer dereference in the related printing kthread, which assumes it can call that callback.

Do not create kthreads for consoles that do not implement the write() callback. Also, for pr_flush(), ignore consoles that do not implement write() or write_atomic(), since there is no way those consoles can flush their output.

---
 kernel/printk/printk.c | 6 ++++++
 1 file changed, 6 insertions(+)
kernel/printk/printk.c +6 -0
index d2205872304d..64747c72fbea 100644
@@ -2267,6 +2267,10 @@ static int printk_kthread_func(void *data)
 /* Must be called within console_lock(). */
 static void start_printk_kthread(struct console *con)
 {
+	/* No need to start a printing thread if the console cannot print. */
+	if (!con->write)
+		return;
+
 	con->thread = kthread_run(printk_kthread_func, con,
 				  "pr/%s%d", con->name, con->index);
 	if (IS_ERR(con->thread)) {
@@ -3566,6 +3570,8 @@ bool pr_flush(int timeout_ms, bool reset_on_progress)
 		for_each_console(con) {
 			if (!(con->flags & CON_ENABLED))
 				continue;
+			if (!con->write && !con->write_atomic)
+				continue;
 			printk_seq = atomic64_read(&con->printk_seq);
 			if (printk_seq < seq)
 				diff += seq - printk_seq;
Signature · 1 line
2.30.2
#4 lore raw
Quoted 4 lines · John Ogness

The ttynull driver does not provide an implementation for the write() callback. This leads to a NULL pointer dereference in the related printing kthread, which assumes it can call that callback.

Quoted 8 lines

Do not create kthreads for consoles that do not implement the write() callback. Also, for pr_flush(), ignore consoles that do not implement write() or write_atomic(), since there is no way those consoles can flush their output.

Thank you! I will apply that to the next 5.10-rt build.

Luis

Quoted 31 lines
---
 kernel/printk/printk.c | 6 ++++++
 1 file changed, 6 insertions(+)
kernel/printk/printk.c +6 -0
index d2205872304d..64747c72fbea 100644
@@ -2267,6 +2267,10 @@ static int printk_kthread_func(void *data)
 /* Must be called within console_lock(). */
 static void start_printk_kthread(struct console *con)
 {
+	/* No need to start a printing thread if the console cannot print. */
+	if (!con->write)
+		return;
+
 	con->thread = kthread_run(printk_kthread_func, con,
 				  "pr/%s%d", con->name, con->index);
 	if (IS_ERR(con->thread)) {
@@ -3566,6 +3570,8 @@ bool pr_flush(int timeout_ms, bool reset_on_progress)
 		for_each_console(con) {
 			if (!(con->flags & CON_ENABLED))
 				continue;
+			if (!con->write && !con->write_atomic)
+				continue;
 			printk_seq = atomic64_read(&con->printk_seq);
 			if (printk_seq < seq)
 				diff += seq - printk_seq;
Signature · 1 line
2.30.2

---end quoted text---

#5 lore raw
In reply to John Ogness
Quoted 4 lines · John Ogness

The ttynull driver does not provide an implementation for the write() callback. This leads to a NULL pointer dereference in the related printing kthread, which assumes it can call that callback.

Quoted 8 lines

Do not create kthreads for consoles that do not implement the write() callback. Also, for pr_flush(), ignore consoles that do not implement write() or write_atomic() since there is no way those consoles can flush their output.

---
This is only a problem for the PREEMPT_RT tree. Mainline does not have this problem.

Sorry for resurrecting this old thread but we actually want this patch in 5.15-rt.

I am not sure why this was not applied to 5.15-rt yet since it is already applied to 5.10-rt.

Could you please consider to pick this for 5.15-rt?

Best regards,
Krishanth

#6 lore raw

Re: [External] : Re: [PATCH 5.15-rt] printk: ignore consoles without write() callback

Quoted 16 lines · Krishanth Jagaduri
Quoted 4 lines · John Ogness

The ttynull driver does not provide an implementation for the write() callback. This leads to a NULL pointer dereference in the related printing kthread, which assumes it can call that callback.

Quoted 8 lines

Do not create kthreads for consoles that do not implement the write() callback. Also, for pr_flush(), ignore consoles that do not implement write() or write_atomic() since there is no way those consoles can flush their output.

---
This is only a problem for the PREEMPT_RT tree. Mainline does not have this problem.

Sorry for resurrecting this old thread but we actually want this patch in 5.15-rt.

Quoted 7 lines

I am not sure why this was not applied to 5.15-rt yet since it is already applied to 5.10-rt.

Could you please consider to pick this for 5.15-rt?

Best regards,
Krishanth

Hi Krishanth,

Thanks for pointing this out.  I will investigate including this patch in the next v5.15 patch set, which should be released this week.

Thanks,

Joe

#7 lore raw

Re: [External] : Re: [PATCH 5.15-rt] printk: ignore consoles without write() callback

Quoted 8 lines · Joseph Salisbury

Hi Krishanth,

Thanks for pointing this out.  I will investigate including this patch in the next v5.15 patch set, which should be released this week.

Thanks,

Joe

Thank you for including this patch in v5.15.183-rt85.

Best regards,
Krishanth

#8 lore raw

Re: [External] : Re: [PATCH 5.15-rt] printk: ignore consoles without write() callback

Quoted 6 lines · Krishanth Jagaduri
Quoted 5 lines · Joseph Salisbury

Hi Krishanth,

Thanks for pointing this out.  I will investigate including this patch in the next v5.15 patch set, which should be released this week.

Quoted 7 lines
Quoted 3 lines

Thanks,

Joe

Thank you for including this patch in v5.15.183-rt85.

Best regards,
Krishanth

Not a problem, Krishanth! Just let me know if you run into any issues.

Thanks,

Joe

#9 lore raw

Re: [External] : Re: [PATCH 5.15-rt] printk: ignore consoles without write() callback

Quoted 14 lines · Joseph Salisbury
Quoted 11 lines · Krishanth Jagaduri
Quoted 8 lines · Joseph Salisbury

Hi Krishanth,

Thanks for pointing this out.  I will investigate including this patch in the next v5.15 patch set, which should be released this week.

Thanks,

Joe

Thank you for including this patch in v5.15.183-rt85.

Quoted 8 lines
Quoted 2 lines

Best regards,
Krishanth

Not a problem, Krishanth! Just let me know if you run into any issues.

Thanks,

Joe

Sure, I will let you know if any.

Best regards,
Krishanth