Skip to contentSkip to conversation

lnussel/su-v1: Portability patch for GNU/Hurd

PATCH New Thomas Schwinge 1 participant 4 messages May 25, 2012 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi!

Only the first (and tiny) patch is needed for portability; the other two are just general clean-up.

Then, su appears to work -- based on a bit of manual testing that I have just done.

Grüße,
Thomas

#2 lore raw

PATCH 1/3 su: Don't include the unused <sys/fsuid.h>.

---
 login-utils/su.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
login-utils/su.c +0 -1
index edd6d10..29042f0 100644
@@ -81,7 +81,6 @@ enum
 # include <security/pam_misc.h>
 # include <signal.h>
 # include <sys/wait.h>
-# include <sys/fsuid.h>
 #endif
 
 #if HAVE_SYSLOG_H && HAVE_SYSLOG
Signature · 1 line
1.7.9
#3 lore raw

PATCH 2/3 su: Add AM_LDFLAGS to su_LDFLAGS.

In reply to Thomas Schwinge
---
 login-utils/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
login-utils/Makefile.am +1 -1
index 60e6f10..d376234 100644
@@ -89,7 +89,7 @@ su_CFLAGS = -DUSE_PAM=1 $(SUID_CFLAGS) $(AM_CFLAGS)
 chfn_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
 chsh_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
 newgrp_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
-su_LDFLAGS = $(SUID_LDFLAGS)
+su_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
 
 login_ldadd_common += -lpam -lpam_misc
 
Signature · 1 line
1.7.9
#4 lore raw

PATCH 3/3 su: Mention SUID_* feature.

In reply to Thomas Schwinge
---
 Documentation/howto-compilation.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Documentation/howto-compilation.txt +1 -1
index 3617b34..bebe0d2 100644
@@ -25,7 +25,7 @@ Compiling
 	./configure SUID_CFLAGS="-fpie" SUID_LDFLAGS="-pie"
 
 	The SUID_* feature is currently supported for chfn, chsh,
-	newgrp, write, mount, and umount.
+	newgrp, su, write, mount, and umount.
 
 	Preferred compilation options for developers, when
 	using gcc, are:
Signature · 1 line
1.7.9