omap3 clock framework for clock set_rate

In linux-omap clock framework, most clocks have no set_rate in their definition in clock34xx.h, but defined DEFAULT_RATE in clksel_rate structures, this Will only allow some pre-set rates for some clocks and Can not get a more flexible rates if driver wants to Change the clock rate usng clk_set_rate.

What is the benefit of this implementation?

We want to understand this before we made the change In case we missed some imprtant background of This implementation.

-----Original Message-----
From: Paul Walmsley [mailto:[email protected]]
Sent: 2009年6月19日 8:18
To: Wang Sawsd-A24013
Cc: [email protected]
Subject: Re: [Question] omap3 clock framework for clock set_rate

Hello Chunqiu,

Quoted 7 lines · On Fri, 19 Jun 2009, Wang Sawsd-A24013 wrote:

In linux-omap clock framework, most clocks have no set_rate in their definition in clock34xx.h, but defined DEFAULT_RATE in clksel_rate structures, this Will only allow some pre-set rates for some clocks and Can not get a more flexible rates if driver wants to Change the clock rate usng clk_set_rate.

Quoted 5 lines

What is the benefit of this implementation?

We want to understand this before we made the change In case we missed some imprtant background of This implementation.

Any driver that wishes to change its clock rate should add .set_rate and
.round_rate function pointers to its corresponding clocks. There's no good reason why those function pointers aren't there; they probably
should have been added with the original clock tree.

Hope this helps,

- Paul