Skip to contentSkip to conversation

APM suspend/resume ceased to work with 2.4.28

DISCUSSION Philippe Troin 3 participants 7 messages Nov 22, 2004 – Dec 3, 2004 1 message not in the archive ACPI

lore
Share & tools
lore
#0 lore raw

Seen on a Dell Inspiron 3800 with BIOS revision A17.

APM suspend/resume works perfectly with 2.4.27 (or at least, as well as APM can).

Since I did not see any differences in arch/i386/kernel/apm.c between .27 and .28, I'm at loss to explain the problem.

Phil.

#1 lore raw
Quoted 7 lines · Philippe Troin

Seen on a Dell Inspiron 3800 with BIOS revision A17.

APM suspend/resume works perfectly with 2.4.27 (or at least, as well as APM can).

Since I did not see any differences in arch/i386/kernel/apm.c between .27 and .28, I'm at loss to explain the problem.

Guess: Are you using ACPI ?

:(

#2 lore raw
Quoted 10 lines · Marcelo Tosatti
Quoted 7 lines · Philippe Troin

Seen on a Dell Inspiron 3800 with BIOS revision A17.

APM suspend/resume works perfectly with 2.4.27 (or at least, as well as APM can).

Since I did not see any differences in arch/i386/kernel/apm.c between .27 and .28, I'm at loss to explain the problem.

Guess: Are you using ACPI ?

ACPI is compiled in, but the kernel is booted with noacpi...

Phil.

#3 lore raw
Quoted 8 lines · Philippe Troin
Quoted 6 lines · Marcelo Tosatti
Quoted 5 lines · Philippe Troin

Seen on a Dell Inspiron 3800 with BIOS revision A17.

APM suspend/resume works perfectly with 2.4.27 (or at least, as well as APM can).

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Since I did not see any differences in arch/i386/kernel/apm.c between .27 and .28, I'm at loss to explain the problem.

Guess: Are you using ACPI ?

ACPI is compiled in, but the kernel is booted with noacpi...

Phil.

Phil,

Can you please try 2.4.28-pre3 ?

Lets try to find out where it started to happen. I've got no clue, there are no indeed no APM related changes in 2.4.28.

#4 lore raw
Quoted 16 lines · Marcelo Tosatti
Quoted 15 lines · Philippe Troin
Quoted 10 lines · Marcelo Tosatti
Quoted 7 lines · Philippe Troin

Seen on a Dell Inspiron 3800 with BIOS revision A17.

APM suspend/resume works perfectly with 2.4.27 (or at least, as well as APM can).

Since I did not see any differences in arch/i386/kernel/apm.c between .27 and .28, I'm at loss to explain the problem.

Guess: Are you using ACPI ?

ACPI is compiled in, but the kernel is booted with noacpi...

Quoted 8 lines
Quoted 1 line

Phil.

Phil,

Can you please try 2.4.28-pre3 ?

Lets try to find out where it started to happen. I've got no clue, there are no indeed no APM related changes in 2.4.28.

The bug was introduced between rc1 and rc2.

I'm still working on it to narrow it down to which delta introduced the bug.

I suspect either the ACPI or the APIC/DMI changes.

Phil.

#5 lore raw
In reply to Marcelo Tosatti
Quoted 1 line · Philippe Troin

Where do we go from here?

I just diffed out the boot log between 2.4.27 and 2.4.28. And I found this new message appearing in 2.4.28:

ACPI: IRQ9 SCI: Edge set to Level Trigger.

Weird since IRQ 9 is not in use in this system. IRQ9 is typically used by ACPI.

After some digging in the sources, I found that the newly introduced (2.4.28-rc2) function acpi_early_init() runs wether or not acpi=off was specified on the command line.

This trivial patch makes my laptop suspend-happy. Len, please confirm that this is ok. Marcelo, please include in 29-pre.

Phil.

drivers/acpi/bus.c +3 -0
diff -ruN linux-2.4.28.orig/drivers/acpi/bus.c linux-2.4.28/drivers/acpi/bus.c
@@ -1850,6 +1850,9 @@
 	acpi_status		status = AE_OK;
 	struct acpi_buffer	buffer = {sizeof(acpi_fadt), &acpi_fadt};
 
+	if (acpi_disabled)
+		return;
+
 	ACPI_FUNCTION_TRACE("acpi_bus_init");
 
 	status = acpi_initialize_subsystem();
#6 lore raw
Quoted 3 lines · Philippe Troin

Philippe Troin <[email protected]> writes:

This trivial patch makes my laptop suspend-happy.

Good catch Phil!

My fault -- we fixed this in 2.6 and I failed to backport it to 2.4:-(

I've included your patch w/ minor syntax change to the ACPI patch.

Marcelo, please do a

bk pull bk://linux-acpi.bkbits.net/24-latest-release

thanks,
-Len

ps. a plain patch is also available here:
ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/24-latest-release/acpi-20040326-24-latest-release.diff.gz

This will update the following files:

 drivers/acpi/bus.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)

through these ChangeSets:

<[email protected]> (04/12/02 1.1458.1.9)
[ACPI] acpi=off must disable acpi_early_init()