Skip to contentSkip to conversation

makedumpfile question / request

DISCUSSION Dave Anderson 2 participants 2 messages Apr 17, 2009 – Apr 20, 2009 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 884741448.4880661239996117339.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com

#1 lore raw

Is there a reason that makedumpfile does not fill in the utsname structure in the compressed dumpfile's header?

The data structure does get read into a local new_utsname structure in the check_release() function, but it doesn't get saved and copied into the disk_dump_header in write_kdump_header().

It would be helpful if that were in place as a quick ID for what the compressed dumpfile contains.

Dave

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#2 lore raw

Hi Dave,

Quoted 2 lines · Dave Anderson

Is there a reason that makedumpfile does not fill in the utsname structure in the compressed dumpfile's header?

Thank you for good point.

makedumpfile does not fill it because makedumpfile might not be able to get kernel debug information (containing symbol system_utsname/init_uts_ns). makedumpfile does not need kernel debug information if dump_level is 0 or 1, and it does not read a new_utsname structure. (check_release() is not called.)

Quoted 6 lines

The data structure does get read into a local new_utsname structure in the check_release() function, but it doesn't get saved and copied into the disk_dump_header in write_kdump_header().

It would be helpful if that were in place as a quick ID for what the compressed dumpfile contains.

I feel that is worth.
How about saving new_utsname data into disk_dump_header only if dump_level is 2 or bigger ?

Thanks
Ken'ichi Ohmichi

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec