Skip to contentSkip to conversation

Fix various comment errors

PATCH linmiaohe 2 participants 2 messages Dec 12, 2019 KVM

lore
Share & tools
lore

linmiaohe

author
#0 lore raw
Quoted 19 lines · Sean Christopherson
Quoted 9 lines · linmiaohe

From: Miaohe Lin <[email protected]>

Miaohe Lin (6):
KVM: Fix some wrong function names in comment
KVM: Fix some out-dated function names in comment
KVM: Fix some comment typos and missing parentheses
KVM: Fix some grammar mistakes
KVM: hyperv: Fix some typos in vcpu unimpl info
KVM: Fix some writing mistakes

Regarding the patch organizing, I'd probably group the comment changes based on what files they touch as opposed to what type of comment issue they're fixing.

E.g. three patches for the comments

KVM: VMX: Fix comment blah blah blah
KVM: x86: Fix comment blah blah blah
KVM: Fix comment blah blah blah

Quoted 6 lines

and one patch for the print typo in hyperv

KVM: hyperv: Fix some typos in vcpu unimpl info

For KVM, the splits don't matter _that_ much since they more or less all get routed through the maintainers/reviewers, but it is nice when patches can be contained to specific subsystems/areas as it allows people to easily skip over patches that aren't relevant to them.

Many thanks for your advice and patient explanation. I feel sorry for my poor patch organizing. I would reorganize my patches. Thanks again.

#1 lore raw

Hi,

Quoted 22 lines · linmiaohe
Quoted 21 lines · Sean Christopherson
Quoted 9 lines · linmiaohe

From: Miaohe Lin <[email protected]>

Miaohe Lin (6):
KVM: Fix some wrong function names in comment
KVM: Fix some out-dated function names in comment
KVM: Fix some comment typos and missing parentheses
KVM: Fix some grammar mistakes
KVM: hyperv: Fix some typos in vcpu unimpl info
KVM: Fix some writing mistakes

Regarding the patch organizing, I'd probably group the comment changes based on what files they touch as opposed to what type of comment issue they're fixing.

E.g. three patches for the comments

KVM: VMX: Fix comment blah blah blah
KVM: x86: Fix comment blah blah blah
KVM: Fix comment blah blah blah

and one patch for the print typo in hyperv

Quoted 8 lines
Quoted 4 lines

KVM: hyperv: Fix some typos in vcpu unimpl info

For KVM, the splits don't matter _that_ much since they more or less all get routed through the maintainers/reviewers, but it is nice when patches can be contained to specific subsystems/areas as it allows people to easily skip over patches that aren't relevant to them.

Many thanks for your advice and patient explanation. I feel sorry for my poor patch organizing. I would reorganize my patches. Thanks again.

Could you please use the "In-Reply-To" tag when you reply a mail next time? Otherwise every replying mail from you is listed as a separate one, but not folded into the initial thread in my mail client.