pwm: fi pwm-rz-mtu3.c build errors
Subsystems (2)
PATCH 1/1 pwm: fi pwm-rz-mtu3.c build errors
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld: drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld: drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld: drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld: drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld: drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'
Modify the dependencies of PWM_RZ_MTU3 so that COMPILE_TEST is still allowed but PWM_RZ_MTU3 depends on RZ_MTU3 if it is being built but also allow the latter not to be built.
--- drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/pwm/Kconfig +2 -1
@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=n depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found in Renesas
Hi Randy Dunlap,
Thanks for the feedback.
Quoted 5 lines
Subject: [PATCH] pwm: fi
pwm-rz-mtu3.cbuild errorsFrom: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
Recently added module support for RZ_MTU3[1]. ie, after adding PWM support.
Quoted 50 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.
Quoted 6 lines
Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>
Cheers,
Biju
Quoted 18 lines
--- drivers/pwm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff -- a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
drivers/pwm/Kconfig +2
-1@@ -505,7 +505,8 @@ config PWM_ROCKCHIP config PWM_RZ_MTU3 tristate "Renesas RZ/G2L MTU3a PWM Timer support" - depends on RZ_MTU3 || COMPILE_TEST + depends on COMPILE_TEST + depends on RZ_MTU3 || RZ_MTU3=n depends on HAS_IOMEM help This driver exposes the MTU3a PWM Timer controller found inRenesas
Quoted 5 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>
Oops, I should resend that with corrected email addresses. Sorry.
Signature · 1 line
~Randy
Quoted 10 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Tuesday, July 18, 2023 7:38 AM
To: [email protected]; [email protected]
Cc: Uwe Kleine-König <[email protected]>; Thierry Reding <[email protected]>; Biju Das <[email protected]>
Subject: Re: [PATCH] pwm: fipwm-rz-mtu3.cbuild errors
Quoted 8 lines
Quoted 5 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>Oops, I should resend that with corrected email addresses. Sorry.
Also typo in patch header "pwm: fi pwm-rz-mtu3.c build errors" ??
Not sure fixes tag should beb8b28b718ddd ("mfd: Add module build support for RZ/G2L MTU3a") or254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")
Cheers,
Biju
Quoted 14 lines · Biju Das
Quoted 14 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Tuesday, July 18, 2023 7:38 AM
To: [email protected]; [email protected]
Cc: Uwe Kleine-König <[email protected]>; Thierry Reding <[email protected]>; Biju Das <[email protected]>
Subject: Re: [PATCH] pwm: fipwm-rz-mtu3.cbuild errorsQuoted 3 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>Oops, I should resend that with corrected email addresses. Sorry.
Also typo in patch header "pwm: fi
pwm-rz-mtu3.cbuild errors" ??
Yes, I saw & fixed that one.
Quoted 4 lines
Not sure fixes tag should be
b8b28b718ddd("mfd: Add module build support for RZ/G2L MTU3a") or254d3a727421("pwm: Add Renesas RZ/G2L MTU3a PWM driver")
It's the PWM Kconfig entry that is incorrect AFAICT.
thanks.
Signature · 1 line
~Randy
Hi Randy Dunlap,
Quoted 31 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Tuesday, July 18, 2023 7:45 AM
To: Biju Das <[email protected]>; [email protected]; [email protected]
Cc: Uwe Kleine-König <[email protected]>; Thierry Reding <[email protected]>
Subject: Re: [PATCH] pwm: fipwm-rz-mtu3.cbuild errorsQuoted 14 lines · Biju Das
Quoted 14 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Tuesday, July 18, 2023 7:38 AM
To: [email protected]; [email protected]
Cc: Uwe Kleine-König <[email protected]>; Thierry Reding <[email protected]>; Biju Das <[email protected]>
Subject: Re: [PATCH] pwm: fipwm-rz-mtu3.cbuild errorsQuoted 3 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>Oops, I should resend that with corrected email addresses. Sorry.
Also typo in patch header "pwm: fi
pwm-rz-mtu3.cbuild errors" ??
Quoted 7 lines
Yes, I saw & fixed that one.
Quoted 3 lines
Not sure fixes tag should be
b8b28b718ddd("mfd: Add module build support for RZ/G2L MTU3a") or254d3a727421("pwm: Add Renesas RZ/G2L MTU3a PWM driver")It's the PWM
Kconfigentry that is incorrect AFAICT.
OK got it.
Cheers,
Biju
Hello,
Quoted 37 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to `rz_mtu3_8bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to `rz_mtu3_16bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to `rz_mtu3_16bit_ch_write'
ld: vmlinux.o: in function `rz_mtu3_pwm_config':drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to `rz_mtu3_disable'
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to `rz_mtu3_8bit_ch_write'
ld:drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to `rz_mtu3_is_enabled'
ld:drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to `rz_mtu3_8bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to `rz_mtu3_16bit_ch_read'
ld:drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to `rz_mtu3_16bit_ch_read'
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to `rz_mtu3_8bit_ch_read'Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.
Quoted 6 lines
Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>
While testing here I hit another (unrelated) problem:
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function ‘rzg2l_gpio_free’:drivers/pinctrl/renesas/pinctrl-rzg2l.c:917:37: error: ‘struct gpio_chip’ has no member named ‘irq’
917 | virq = irq_find_mapping(chip->irq.domain, offset);
| ^~
Did someone address that one already? I guess PINCTRL_RZG2L should select GPIOLIB_IRQCHIP. Also RZ_MTU3 should select MFD_CORE as I hit:
aarch64-linux-gnu-ld: rz-mtu3.c:(.text+0x544): undefined reference to `mfd_remove_devices'
Commit 654c293e1687b31819f9bf1ac71b5a85a8053210 added RZ_MTU3 as bool, and it's still bool in 254d3a72742. I think the problem started only with b8b28b718ddd ("mfd: Add module build support for RZ/G2L MTU3a").
The patch looks fine, but the commit log needs some adaption.
The following patch would fix the build failure, too:
include/linux/mfd/rz-mtu3.h +1 -1
@@ -151,7 +151,7 @@ struct rz_mtu3 {void *priv_data; }; -#if IS_ENABLED (CONFIG_RZ_MTU3 ) +#if IS_REACHABLE (CONFIG_RZ_MTU3 )static inline bool rz_mtu3_request_channel (struct rz_mtu3_channel *ch) {mutex_lock (&ch->lock);
maybe doing that additionally is a good idea? (Well, not entirely sure as the above setting then would result in a non-functioning PWM driver. Maybe that's worse than a build failure?)
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
HI Uwe and Randy,
Quoted 83 lines
-----Original Message-----
From: Uwe Kleine-König <[email protected]>
Sent: Tuesday, July 18, 2023 10:00 AM
To: Randy Dunlap <[email protected]>
Cc: [email protected]; [email protected]; Thierry Reding <[email protected]>; Biju Das <[email protected]>; Lee Jones <[email protected]>
Subject: Re: [PATCH] pwm: fipwm-rz-mtu3.cbuild errorsHello,
Quoted 7 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':
drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to`rz_mtu3_16bit_ch_write'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':
drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to`rz_mtu3_16bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to`rz_mtu3_16bit_ch_write'
Quoted 4 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to`rz_mtu3_disable'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':
drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to`rz_mtu3_enable'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':
drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to`rz_mtu3_is_enabled'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to`rz_mtu3_8bit_ch_read'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':
drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to`rz_mtu3_16bit_ch_read'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to`rz_mtu3_16bit_ch_read'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to`rz_mtu3_16bit_ch_read'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':
drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to`rz_mtu3_8bit_ch_read'
Quoted 11 lines
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>While testing here I hit another (unrelated) problem:
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function ‘rzg2l_gpio_free’:drivers/pinctrl/renesas/pinctrl-rzg2l.c:917:37: error: ‘struct gpio_chip’ has no member named ‘irq’
917 | virq =irq_find_mapping(chip->irq.domain, offset);
| ^~Did someone address that one already? I guess
PINCTRL_RZG2Lshould selectGPIOLIB_IRQCHIP. AlsoRZ_MTU3should selectMFD_COREas I hit:
Quoted 6 lines
aarch64-linux-gnu-ld: rz-mtu3.c:(.text+0x544): undefined referenceto `mfd_remove_devices'
Commit
654c293e1687b31819f9bf1ac71b5a85a8053210addedRZ_MTU3as bool, and it's still bool in254d3a72742. I think the problem started only withb8b28b718ddd("mfd: Add module build support for RZ/G2L MTU3a").
So far PWM is build tested with
RZ_MTU3=y , PWM_RZ_MTU3=y and m, RZ_MTU3_CNT = y, m
RZ_MTU3=m , PWM_RZ_MTU3=m, RZ_MTU3_CNT = y
But I have n't build tested this configuration
RZ_MTU3=m , PWM_RZ_MTU3=y, RZ_MTU3_CNT =y
This is invalid configuration, as MTU is core driver and PWM/Counter drivers depend upon that
Maybe any one of PWM_RZ_MTU3 or RZ_MTU3_CNT =y, RZ_MTU3 should be selected as y.
Cheers,
Biju
Quoted 29 lines
The patch looks fine, but the commit log needs some adaption.
The following patch would fix the build failure, too:
include/linux/mfd/rz-mtu3.h +1
-1@@ -151,7 +151,7 @@ struct rz_mtu3 {void *priv_data; }; -#if IS_ENABLED (CONFIG_RZ_MTU3 ) +#if IS_REACHABLE (CONFIG_RZ_MTU3 )static inline bool rz_mtu3_request_channel (struct rz_mtu3_channel *ch) {mutex_lock (&ch->lock);maybe doing that additionally is a good idea? (Well, not entirely sure as the above setting then would result in a non-functioning PWM driver. Maybe that's worse than a build failure?)
Best regards
Uwe--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Hi Uwe,
Thanks for the feedback.
Quoted 80 lines
-----Original Message-----
From: Uwe Kleine-König <[email protected]>
Sent: Tuesday, July 18, 2023 10:00 AM
To: Randy Dunlap <[email protected]>
Cc: [email protected]; [email protected]; Thierry Reding <[email protected]>; Biju Das <[email protected]>; Lee Jones <[email protected]>
Subject: Re: [PATCH] pwm: fipwm-rz-mtu3.cbuild errorsHello,
Quoted 7 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
When (MFD) RZ_MTU3=m and PWM_RZ_MTU3=y, there are numerous build errors:
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:374: undefined reference to `rz_mtu3_disable'
ld:drivers/pwm/pwm-rz-mtu3.c:377: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':
drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to`rz_mtu3_16bit_ch_write'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:382: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_write_tgr_registers':
drivers/pwm/pwm-rz-mtu3.c:110: undefined reference to`rz_mtu3_16bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:111: undefined reference to`rz_mtu3_16bit_ch_write'
Quoted 4 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_config':
drivers/pwm/pwm-rz-mtu3.c:397: undefined reference to `rz_mtu3_enable'
ld: vmlinux.o: in function `rz_mtu3_pwm_disable':drivers/pwm/pwm-rz-mtu3.c:259: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:264: undefined reference to`rz_mtu3_disable'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_enable':
drivers/pwm/pwm-rz-mtu3.c:230: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:234: undefined reference to`rz_mtu3_8bit_ch_write'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:238: undefined reference to`rz_mtu3_enable'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_is_ch_enabled':
drivers/pwm/pwm-rz-mtu3.c:155: undefined reference to`rz_mtu3_is_enabled'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:162: undefined reference to`rz_mtu3_8bit_ch_read'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_read_tgr_registers':
drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to`rz_mtu3_16bit_ch_read'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:102: undefined reference to`rz_mtu3_16bit_ch_read'
Quoted 1 line
ld:
drivers/pwm/pwm-rz-mtu3.c:103: undefined reference to`rz_mtu3_16bit_ch_read'
Quoted 2 lines
ld: vmlinux.o: in function `rz_mtu3_pwm_get_state':
drivers/pwm/pwm-rz-mtu3.c:296: undefined reference to`rz_mtu3_8bit_ch_read'
Quoted 11 lines
Modify the dependencies of
PWM_RZ_MTU3so thatCOMPILE_TESTis still allowed butPWM_RZ_MTU3depends onRZ_MTU3if it is being built but also allow the latter not to be built.Fixes 254d3a727421 ("pwm: Add Renesas RZ/G2L MTU3a PWM driver")Signed-off-by Randy Dunlap <[email protected]>Cc Biju Das <[email protected]>Cc Uwe Kleine-König <[email protected]>Cc Thierry Reding <[email protected]>While testing here I hit another (unrelated) problem:
drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function ‘rzg2l_gpio_free’:drivers/pinctrl/renesas/pinctrl-rzg2l.c:917:37: error: ‘struct gpio_chip’ has no member named ‘irq’
917 | virq =irq_find_mapping(chip->irq.domain, offset);
| ^~
Quoted 5 lines
Did someone address that one already? I guess
PINCTRL_RZG2Lshould selectGPIOLIB_IRQCHIP. AlsoRZ_MTU3should selectMFD_COREas I hit:aarch64-linux-gnu-ld: rz-mtu3.c:(.text+0x544): undefined referenceto `mfd_remove_devices'
OK, will add "select MFD_CORE" as pointed out.
Quoted 23 lines
Commit
654c293e1687b31819f9bf1ac71b5a85a8053210addedRZ_MTU3as bool, and it's still bool in254d3a72742. I think the problem started only withb8b28b718ddd("mfd: Add module build support for RZ/G2L MTU3a").The patch looks fine, but the commit log needs some adaption.
The following patch would fix the build failure, too:
include/linux/mfd/rz-mtu3.h +1
-1@@ -151,7 +151,7 @@ struct rz_mtu3 {void *priv_data; }; -#if IS_ENABLED (CONFIG_RZ_MTU3 ) +#if IS_REACHABLE (CONFIG_RZ_MTU3 )static inline bool rz_mtu3_request_channel (struct rz_mtu3_channel *ch) {mutex_lock (&ch->lock);
Quoted 3 lines
maybe doing that additionally is a good idea? (Well, not entirely sure as the above setting then would result in a non-functioning PWM driver. Maybe that's worse than a build failure?)
It makes sense to use IS_REACHABLE over IS_ENABLED in this context.
Also what is your preference for the KConfig solution?
+ depends on RZ_MTU3 || (COMPILE_TEST && RZ_MTU3)
Or
+ depends on COMPILE_TEST
+ depends on RZ_MTU3 || RZ_MTU3=n
Cheers,
Biju