leds: trigger: panic: don't register panic notifier if creating the trigger failed
PATCH v2 1/1 leds: trigger: panic: don't register panic notifier if creating the trigger failed
It doesn't make sense to register the panic notifier if creating the panic trigger failed.
Signed-off-by Heiner Kallweit <[email protected]>
---
v2:
- don't ignore error and return -ENOMEM if creating the trigger failed
--- drivers/leds/trigger/ledtrig-panic.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/leds/trigger/ledtrig-panic.c +4 -1
@@ -64,10 +64,13 @@ static long led_panic_blink(int state)static int __init ledtrig_panic_init (void ) { +led_trigger_register_simple ("panic" , &trigger); +if (!trigger) +return -ENOMEM ; +atomic_notifier_chain_register (&panic_notifier_list, &led_trigger_panic_nb); -led_trigger_register_simple ("panic" , &trigger); panic_blink = led_panic_blink;return 0 ; }
Signature · 1 line
2.43.0
Re: (subset) [PATCH v2] leds: trigger: panic: don't register panic notifier if creating the trigger failed
Quoted 4 lines · Heiner Kallweit
It doesn't make sense to register the panic notifier if creating the panic trigger failed.
Applied, thanks!
[1/1] leds: trigger: panic: don't register panic notifier if creating the trigger failed
commit: afacb21834bb02785ddb0c3ec197208803b74faa
--
Lee Jones [李琼斯]