Skip to contentSkip to conversation

ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022

PATCH Superseded Mingcong Bai 3 participants 5 messages Nov 1, 2024 – Nov 6, 2024

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022

Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its internal microphone to be enabled.

This is likely due to similar reasons as seen previously on Redmi Book 14/15 Pro 2022 models (since they likely came with similar firmware):

- dcff8b7ca92d724bdaf474a3fa37a7748377813a (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 15 2022 into DMI table)
- c1dd6bf6199752890d8c59d895dd45094da51d1f (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 14 2022 into DMI table)

A quirk would likely be needed for Xiaomi Book Pro 15 2022 models, too. However, I do not have such device on hand so I will leave it for now.

---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -0
index 438865d5e376..dc476bfb6da4 100644
@@ -395,6 +395,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Redmi Book Pro 15 2022"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "TIMI"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14 2022"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
Signature · 1 line
2.47.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Mingcong Bai

Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its internal microphone to be enabled.

This is likely due to similar reasons as seen previously on Redmi Book 14/15 Pro 2022 models (since they likely came with similar firmware):

- dcff8b7ca92d724bdaf474a3fa37a7748377813a (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 15 2022 into DMI table)
- c1dd6bf6199752890d8c59d895dd45094da51d1f (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 14 2022 into DMI table)

Quoted 4 lines

A quirk would likely be needed for Xiaomi Book Pro 15 2022 models, too. However, I do not have such device on hand so I will leave it for now.

Yes makes sense this is a Rembrandt laptop.

Quoted 23 lines
---
  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
  1 file changed, 7 insertions(+)
sound/soc/amd/yc/acp6x-mach.c +7 -0
index 438865d5e376..dc476bfb6da4 100644
@@ -395,6 +395,13 @@ static const struct dmi_system_id 
 yc_acp_quirk_table[] = {
              DMI_MATCH(DMI_PRODUCT_NAME, "Redmi Book Pro 15 2022"),
          }
      },
+    {
+        .driver_data = &acp6x_card,
+        .matches = {
+            DMI_MATCH(DMI_BOARD_VENDOR, "TIMI"),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Xiaomi Book Pro 14 2022"),
+        }
+    },
      {
          .driver_data = &acp6x_card,

         .matches = {

maintainer
#2 lore raw
In reply to Mingcong Bai
Quoted 2 lines · Mingcong Bai

Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its internal microphone to be enabled.

This doesn't apply against current code, please check and resend.

Applying: ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022
error: git diff header lacks filename information when removing 1 leading pathname component (line 6)
error: could not build fake ancestor
Patch failed at 0001 ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022

#3 lore raw

Hi Mark,

Quoted 10 lines · 在 2024-11-06 03:11,Mark Brown 写道:
Quoted 2 lines · Mingcong Bai

Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its internal microphone to be enabled.

This doesn't apply against current code, please check and resend.

Applying: ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022
error: git diff header lacks filename information when removing 1 leading pathname component (line 6)
error: could not build fake ancestor
Patch failed at 0001 ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022

Patch rebased against latest master with minor revisions to message format (I forgot to run checkpatch.pl last time). I have just re-sent the patch as v2. Thanks!

Best Regards,
Mingcong Bai

maintainer
#4 lore raw
In reply to Mingcong Bai
Quoted 6 lines · Mingcong Bai

Xiaomi Book Pro 14 2022 (MIA2210-AD) requires a quirk entry for its internal microphone to be enabled.

This is likely due to similar reasons as seen previously on Redmi Book 14/15 Pro 2022 models (since they likely came with similar firmware):

Quoted 6 lines

- dcff8b7ca92d724bdaf474a3fa37a7748377813a (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 15 2022 into DMI table)
- c1dd6bf6199752890d8c59d895dd45094da51d1f (ASoC: amd: yc: Add Xiaomi Redmi Book Pro 14 2022 into DMI table)

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: fix internal mic on Xiaomi Book Pro 14 2022

      commit: de156f3cf70e17dc6ff4c3c364bb97a6db961ffd

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark