Skip to contentSkip to conversation

acp3x: Missing product ID for Thinkpad T14s Gen2 AMD Ryzen 7 PRO 5850U

PATCH New Bagas Sanjaya 3 participants 8 messages Nov 16, 2023 – Nov 20, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi,

I notice a bug report on Bugzilla [1]. Quoting from it:

Quoted 11 lines

Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. My audio output is fine but my internal microphone cannot be found.

Running dmidecode yields:

Handle 0x000F, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 20XGS1KT02
Version: ThinkPad T14s Gen 2a

Quoted 4 lines

Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?

It seems as there have been similar problems in the past, e.g. https://bugzilla.kernel.org/show_bug.cgi?id=216270.

See Bugzilla for the full thread.

ollisieber, can you send the quirk patch?

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218148

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#1 lore raw

Hi,

thanks for your fast answer. I added my proposed patch as attachment.

Please be aware that this is my first kernel patch.

Thanks a lot!

Quoted 18 lines · Bagas Sanjaya

Hi,

I notice a bug report on Bugzilla [1]. Quoting from it:

Quoted 14 lines

Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. My audio output is fine but my internal microphone cannot be found.

Running dmidecode yields:

Handle 0x000F, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 20XGS1KT02
Version: ThinkPad T14s Gen 2a

Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?

Quoted 9 lines
Quoted 1 line

It seems as there have been similar problems in the past, e.g. https://bugzilla.kernel.org/show_bug.cgi?id=216270.

See Bugzilla for the full thread.

ollisieber, can you send the quirk patch?

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218148

sound/soc/amd/renoir/rn-pci-acp3x.c +7 -0
index b3812b70f5f9..754e24d55e6f 100644
@@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] = {
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"),
 		}
 	},
+	{
+		/* Lenovo ThinkPad T14s Gen 2 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"),
+		}
+	},
 	{}
 };
 
#2 lore raw
Quoted 6 lines · Oliver Sieber

Hi,

thanks for your fast answer. I added my proposed patch as attachment.

Please be aware that this is my first kernel patch.

Please don't top-post; reply inline with appropriate context instead.

Your patch is attached, please send it inline instead. See Documentation/process/submitting-patches.rst for how to do that.

Thanks.

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#3 lore raw

Hi,

in the following I provide my proposed patch for the bug report on Bugzilla [1]. Let me quote from it:

Quoted 11 lines

Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. My audio output is fine but my internal microphone cannot be found.

Running dmidecode yields:

Handle 0x000F, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 20XGS1KT02
Version: ThinkPad T14s Gen 2a

Quoted 4 lines

Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?

It seems as there have been similar problems in the past, e.g.https://bugzilla.kernel.org/show_bug.cgi?id=216270.

My proposed diff looks as follows:

sound/soc/amd/renoir/rn-pci-acp3x.c +0 -0
index b3812b70f5f9..754e24d55e6f 100644
@@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] = {

             DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"), }
     },
+    {
+        /* Lenovo ThinkPad T14s Gen 2 */
+        .matches = {
+            DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), +            DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"), +        }
+    },
     {}
 };

Please have in mind that this is my first patch for the kernel.

Thanks!
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218148

#4 lore raw
Quoted 44 lines · Oliver Sieber

Hi,

in the following I provide my proposed patch for the bug report on Bugzilla [1]. Let me quote from it:

Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. My audio output is fine but my internal microphone cannot be found.

Running dmidecode yields:

Handle 0x000F, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 20XGS1KT02
Version: ThinkPad T14s Gen 2a

Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?

It seems as there have been similar problems in the past, e.g. https://bugzilla.kernel.org/show_bug.cgi?id=216270.

My proposed diff looks as follows:

sound/soc/amd/renoir/ renamed from sound/soc/amd/renoir/rn-pci-acp3x.c +0 -0

rn-pci-acp3x.c
index b3812b70f5f9..754e24d55e6f 100644

sound/soc/amd/renoir/rn-pci-acp3x.c +7 -0
@@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] =
 {
              DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"),
          }
      },
+    {
+        /* Lenovo ThinkPad T14s Gen 2 */
+        .matches = {
+            DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+            DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"),
+        }
+    },
      {}
  };
Quoted 1 line

Please have in mind that this is my first patch for the kernel.

The kernel patch should be in a proper format, so that it can be merged to the upstream. e.g. The Subject line should have a brief description with the proper prefix for the corresponding subsystem (in your case, something like "ASoC: amd:"). It'll follow the patch description, as well as your proper Signed-off-by tag.

The details are found in
https://docs.kernel.org/process/submitting-patches.html

Could you resubmit the patch in a proper format?

thanks,

Takashi

#6 lore raw
In reply to Oliver Sieber
Quoted 51 lines · Oliver Sieber

Hi,

in the following I provide my proposed patch for the bug report on Bugzilla [1]. Let me quote from it:

Quoted 11 lines

Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. My audio output is fine but my internal microphone cannot be found.

Running dmidecode yields:

Handle 0x000F, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 20XGS1KT02
Version: ThinkPad T14s Gen 2a

Quoted 4 lines

Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?

It seems as there have been similar problems in the past, e.g.https://bugzilla.kernel.org/show_bug.cgi?id=216270.

My proposed diff looks as follows:

Subject: ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad T14s Gen 2
From: Oliver Sieber
The ThinkPad T14s Gen 2 laptop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec.

Use DMI to block the microphone PCM device for this platform.

---

sound/soc/amd/renoir/rn-pci-acp3x.c +7 -0
index b3812b70f5f9..754e24d55e6f 100644
@@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[]
 = {
                         DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"),
                 }
         },
+       {
+               /* Lenovo ThinkPad T14s Gen 2 */
+               .matches = {
+                       DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"),
+               }
+       },
         {}
 
Quoted 2 lines

 };

Hi Oliver,

Did you forget Takashi's suggestion to follow formal patch submission procedure [1]? Hint: It is suggested to use git-send-email(1) when sending patches, as it handles them as-is (e.g. no wordwrapping, tabs preserved).

Thanks.

[1]: https://lore.kernel.org/alsa-devel/[email protected]/

Signature · 1 line
An old man doll... just what I always wanted! - Clara
#7 lore raw

PATCH 1/1 Subject: ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad T14s Gen 2

The ThinkPad T14s Gen 2 latop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec.

Use DMI to block the microphone PCM device for this platform.

---
 sound/soc/amd/renoir/rn-pci-acp3x.c | 7 +++++++
 1 file changed, 7 insertions(+)
sound/soc/amd/renoir/rn-pci-acp3x.c +7 -0
index b3812b70f5f9..754e24d55e6f 100644
@@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] = {
 			DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"),
 		}
 	},
+	{
+		/* Lenovo ThinkPad T14s Gen 2 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"),
+		}
+	},
 	{}
 };
 
Signature · 1 line
2.34.1
#5 lore raw
In reply to Takashi Iwai

Hi,

in the following I provide my proposed patch for the bug report on Bugzilla [1]. Let me quote from it:

Quoted 11 lines

Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks. It seems like some product IDs may be missing. In my case, I am using a Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U. My audio output is fine but my internal microphone cannot be found.

Running dmidecode yields:

Handle 0x000F, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 20XGS1KT02
Version: ThinkPad T14s Gen 2a

Quoted 4 lines

Could it be that one may have to add the product ID "20XGS1KT02" to the hard-coded list of quirks in rn-pci-acp3x.c?

It seems as there have been similar problems in the past, e.g.https://bugzilla.kernel.org/show_bug.cgi?id=216270.

My proposed diff looks as follows:

Subject: ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad T14s Gen 2
From: Oliver Sieber
The ThinkPad T14s Gen 2 laptop does not have the internal digital microphone connected to the AMD's ACP bridge, but it's advertised via BIOS. The internal microphone is connected to the HDA codec.

Use DMI to block the microphone PCM device for this platform.

---

sound/soc/amd/renoir/rn-pci-acp3x.c +0 -0
index b3812b70f5f9..754e24d55e6f 100644
@@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table[] = {

                        DMI_EXACT_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"), }
        },
+       {
+               /* Lenovo ThinkPad T14s Gen 2 */
+               .matches = {
+                       DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "LENOVO"), +                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "20XGS1KT02"), +               }
+       },
        {}

 };

Please have in mind that this is my first patch for the kernel.

Thanks!
[1]: https://bugzilla.kernel.org/show_bug.cgi?id=218148