adding lockdep support to the Blackfin arch
ive been extending the Blackfin arch recently to support lockdep. since i also had to implement irqflags/stacktrace as well, i wouldnt be surprised if this issue is nested in there, plus this is a no-mmu system.
at any rate, when i boot up a Blackfin system with PROVE_LOCKING enabled, i end up with this warning:
Badness at kernel/fork.c:988
which correlates to this in copy_process():
DEBUG_LOCKS_WARN_ON(!p->hardirqs_enabled);
btw, in order to get this to work in the first place, i had to extend -mike
Quoted 11 lines · Mike Frysinger
ive been extending the Blackfin arch recently to support lockdep. since i also had to implement irqflags/stacktrace as well, i wouldnt be surprised if this issue is nested in there, plus this is a no-mmu system.
at any rate, when i boot up a Blackfin system with
PROVE_LOCKINGenabled, i end up with this warning:
Badness atkernel/fork.c:988which correlates to this in
copy_process():
DEBUG_LOCKS_WARN_ON(!p->hardirqs_enabled);
sorry, stupid stuck keys triggered gmail sending before i finished
when i trace the code, i can see hardirqs_enabled toggling between 0 and 1 ... but when it makes it to copy_process(), apparently it's 0 which annoys the lockdep code. any tips for me ?
btw, in order to get this to work in the first place, i had to extend kernel/lockdep.c's static_obj() function as the Blackfin has custom data regions where some locks live (thus outside of the normal start/end map). should this code use kallsyms' helper functions instead ? otherwise, i needed this:
kernel/lockdep.c +21 -0
@@ -634,6 +634,27 @@ static int static_obj(void *obj)if ((addr >= start) && (addr < end))return 1 ; +#ifdef CONFIG_BLACKFIN +if (L1_DATA_A_LENGTH ) { + start = (unsigned long ) &_sdata_l1; + end = (unsigned long ) &_ebss_l1; +if ((addr >= start) && (addr < end)) +return 1 ; + } +if (L1_DATA_B_LENGTH ) { + start = (unsigned long ) &_sdata_b_l1; + end = (unsigned long ) &_ebss_b_l1; +if ((addr >= start) && (addr < end)) +return 1 ; + } +if (L2_LENGTH ) { + start = (unsigned long ) &_sdata_l2; + end = (unsigned long ) &_ebss_l2; +if ((addr >= start) && (addr < end)) +return 1 ; + } +#endif +#ifdef CONFIG_SMP /* * percpu var?
-mike
Quoted 11 lines · Mike Frysinger
ive been extending the Blackfin arch recently to support lockdep. since i also had to implement irqflags/stacktrace as well, i wouldnt be surprised if this issue is nested in there, plus this is a no-mmu system.
at any rate, when i boot up a Blackfin system with
PROVE_LOCKINGenabled, i end up with this warning:
Badness atkernel/fork.c:988which correlates to this in
copy_process():DEBUG_LOCKS_WARN_ON(!p->hardirqs_enabled);
This suggests that the irqflags tracking might be wrong: the fork code expects it at this point that hardirqs are enabled.
Quoted 2 lines
btw, in order to get this to work in the first place, i had to extend
[incomplete mail?]
Ingo