Skip to contentSkip to conversation

Fixed GPIO2 value assigned

PATCH Applied Kailang 2 participants 2 messages Feb 13, 2023 Sound

lore
Share & tools
lore

Kailang

author
#0 lore raw

Hi Takashi,

This fix was GPIO2 value 0x3 change to 0x4.
GPIO2 GPIO1 GPIO0
1 0 0 ==> 0x4 ==> GPIO2 HIGH

GPIO2 GPIO1 GPIO0
0 1 1 ==> 0x3 ==> GPIO0 and GPIO1 HIGH

BR,
Kailang

From 76ecb6b4597daf2d034ae7f9566fce611bb72d72 Mon Sep 17 00:00:00 2001
From: Kailang Yang <[email protected]>
Date: Mon, 13 Feb 2023 14:54:22 +0800
Subject: [PATCH] ALSA: hda/realtek - fixed wrong gpio assigned

GPIO2 PIN use for output. Mask Dir and Data need to assign for 0x4. Not 0x3. This fixed was for Lenovo Desktop(0x17aa1056). GPIO2 use for AMP enable.

sound/pci/hda/patch_realtek.c +1 -1
index 1134a493d225..14b84a1f43d3 100644
@@ -832,7 +832,7 @@ static int alc_subsystem_id(struct hda_codec *codec, const hda_nid_t *ports)
 			alc_setup_gpio(codec, 0x02);
 			break;
 		case 7:
-			alc_setup_gpio(codec, 0x03);
+			alc_setup_gpio(codec, 0x04);
 			break;
 		case 5:
 		default:
Applied
#1 lore raw
Quoted 7 lines · Kailang

Hi Takashi,

This fix was GPIO2 value 0x3 change to 0x4.
GPIO2 GPIO1 GPIO0
1 0 0 ==> 0x4 ==> GPIO2 HIGH

Quoted 5 lines

GPIO2 GPIO1 GPIO0
0 1 1 ==> 0x3 ==> GPIO0 and GPIO1 HIGH

BR,
Kailang

Thanks, applied now.

Takashi