Skip to contentSkip to conversation

dm: Add a debug message when devices are skipped pre-reloc

PATCH New Sean Anderson 4 participants 4 messages Dec 25, 2019 – Jan 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm: Add a debug message when devices are skipped pre-reloc

This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.

---
 drivers/core/lists.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/core/lists.c +3 -1
index 4681b3e5dd..68204c303f 100644
@@ -176,8 +176,10 @@ int lists_bind_fdt(struct udevice *parent, ofnode node, struct udevice **devp,
 
 		if (pre_reloc_only) {
 			if (!dm_ofnode_pre_reloc(node) &&
-			    !(entry->flags & DM_FLAG_PRE_RELOC))
+			    !(entry->flags & DM_FLAG_PRE_RELOC)) {
+				log_debug("Skipping device pre-relocation\n");
 				return 0;
+			}
 		}
 
 		log_debug("   - found match at '%s': '%s' matches '%s'\n",
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 dm: Add a debug message when devices are skipped pre-reloc

Quoted 10 lines · Sean Anderson

This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.

---
 drivers/core/lists.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
#2 lore raw

PATCH 1/1 dm: Add a debug message when devices are skipped pre-reloc

In reply to Sean Anderson
Quoted 9 lines · Sean Anderson

This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.

---
 drivers/core/lists.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
#3 lore raw

PATCH 1/1 dm: Add a debug message when devices are skipped pre-reloc

Quoted 9 lines · Sean Anderson

This adds a message to lists_bind_fdt when it skips initializing a device pre-relocation. I've had a couple errors where a device didn't initialize properly because one of its dependencies was missing.

---
 drivers/core/lists.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to u-boot-dm, thanks!