Skip to contentSkip to conversation

soc-camera: camera host driver for i.MX3x SoCs

PATCH Agustin 2 participants 2 messages Feb 19, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Agustin

author
#0 lore raw

Hi Guennadi,
---- Mensaje original ----

Quoted 6 lines

De: Sascha Hauer <[email protected]>

Quoted 4 lines · Guennadi Liakhovetski

From: Guennadi Liakhovetski

Tested with 8 bit Bayer and 8 bit monochrome video.

Quoted 11 lines
Quoted 2 lines
Signed-off-by Guennadi Liakhovetski

---

Acked-by: Sascha Hauer
for the platform part. I can't say much to the driver itself.

Sascha

Quoted 3 lines

This is how I expect this driver to appear in my pull request. So, please, review, test heavily :-)

I want to test it but while applying to mxc-master branch I observed that you use it on top of, at least, framebuffer stuff: #include <mach/mx3fb.h>.

Should I apply fb patchset in order to make this one work? (Otherwise, I can proceed with a minor merging effort.)

I am already using your drivers in their original version, I can get some new pictures with this one pretty soon.

--Agustín.

#1 lore raw

Hi Agustin,

Quoted 17 lines · Agustin

Hi Guennadi,
---- Mensaje original ----

Quoted 15 lines

De: Sascha Hauer <[email protected]>

Quoted 6 lines · Guennadi Liakhovetski

From: Guennadi Liakhovetski

Tested with 8 bit Bayer and 8 bit monochrome video.

Signed-off-by Guennadi Liakhovetski

---

Acked-by: Sascha Hauer
for the platform part. I can't say much to the driver itself.

Sascha

Quoted 1 line
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines

This is how I expect this driver to appear in my pull request. So, please, review, test heavily :-)

I want to test it but while applying to mxc-master branch I observed that you use it on top of, at least, framebuffer stuff: #include <mach/mx3fb.h>.

You probably mean the

[PATCH/FYI 3/4] soc-camera: board bindings for camera host driver for i.MX3x SoCs

patch, not the one you're replying to. And the "3/4" says "FYI", i.e., it is not yet for submission, only for reference.

Quoted 2 lines

Should I apply fb patchset in order to make this one work? (Otherwise, I can proceed with a minor merging effort.)

Well, the camera itself doesn't require the framebuffer. So, if you're not planning to display your video, you can decide for yourself - whether to apply fb patches or to merge camera patches without fb.

Quoted 2 lines

I am already using your drivers in their original version, I can get some new pictures with this one pretty soon.

Great!

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer