DVB driver for Pinnacle PCTV200e and PCTV60e
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
Quoted 10 lines · Juan Antonio Garcia
Hi,
I updated the driver for being supported in kernel 2.6.24 (Ubuntu 8.04).
I am distributing the update thought the Ubuntu forums, but it would be better to distribute it to more users. So Linux has more HW supported.
What it should be done so it is included in the v4l tree?
I forwarded the mail to the linux-dvb ML.
Quoted 9 lines
Now the driver supports 2 devices:
- Pinnacle PCTV 200e
- Pinnacle PCTV 60eThe driver wiki is:
Markus
_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Quoted 22 lines · Markus Rechberger
Hi,
Quoted 10 lines · Juan Antonio Garcia
Hi,
I updated the driver for being supported in kernel 2.6.24 (Ubuntu 8.04).
I am distributing the update thought the Ubuntu forums, but it would be better to distribute it to more users. So Linux has more HW supported.
What it should be done so it is included in the v4l tree?
I forwarded the mail to the linux-dvb ML.
Quoted 5 lines
Now the driver supports 2 devices:
- Pinnacle PCTV 200e
- Pinnacle PCTV 60e
Quoted 6 lines
Quoted 4 lines
The driver wiki is:
Markus
Hi,
This driver seems like it should be trivial to get working on linux-dvb, which is where you want it - the tree you've based it on isn't much longer for this world. (I don't think any of the code you're using has changed significantly between Markus' branch and the main one). It needs some cleanup, though. At a glance:
- Don't use C++-style comments (the single-line // ones)
- The whole "addr == pctv200e_mt2060_config.i2c_address" part looks iffy; I think you should remove this and use i2c_gate_ctrl instead. Unfortunately, I'm not sure this'll work currently, since mt2060 doesn't appear to support it.
- ctrl_msg_last_device/ctrl_msg_last_operation must go - they won't work right if you use multiple devices of this type. The code in the "if (ctrl_msg_last_device == 0)" section can probably go elsewhere, but I'm not sure where
- Why are you incrementing the register value in pctv200e_ctrl_msg?
The linuxtv developers will probably be able to give you more advice.
Aidan
_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb