2.4.9 new min/max definitions are buggy
Leaving aside the question of whether the new min/max functions are sane or not, the 2.4.9 definitions are buggy. If type is a pointer like char *, __x takes pointer type, __y takes base type, splat!
Index: 9.1/include/linux/kernel.h
include/linux/kernel.h Wed, 22 Aug 2001 13:33:28 +1000 kaos (linux-2.4/g/b/11_kernel.h 1.1.1.5 644) renamed from include/linux/kernel.h Tue, 21 Aug 2001 16:48:26 +1000 kaos (linux-2.4/g/b/11_kernel.h 1.1.1.5 644) +2 -2
@@ -113,9 +113,9 @@ static inline void console_verbose(void) ((unsigned char *)&addr)[0] #define min(type,x,y) \ - ({ type __x = (x), __y = (y); __x < __y ? __x: __y; }) + ({ type __x = (x); type __y = (y); __x < __y ? __x: __y; }) #define max(type,x,y) \ - ({ type __x = (x), __y = (y); __x > __y ? __x: __y; }) + ({ type __x = (x); type __y = (y); __x > __y ? __x: __y; }) #endif /* __KERNEL__ */