smb: client: Use common code in smb3_notify()
Subsystems (3)
PATCH 1/1 smb: client: Use common code in smb3_notify()
From: Markus Elfring <[email protected]>
Date: Wed, 8 Oct 2025 22:16:59 +0200
Use an additional label so that a bit of common code can be better reused at the end of this function implementation.
Signed-off-by Markus Elfring <[email protected]>
--- fs/smb/client/smb2ops.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
fs/smb/client/smb2ops.c +9 -8
@@ -2369,15 +2369,12 @@ smb3_notify(const unsigned int xid, struct file *pfile, }if (return_changes) { -if (copy_from_user (¬ify, ioc_buf,sizeof (struct smb3_notify_info ))) { - rc = -EFAULT ; - goto notify_exit; - } +if (copy_from_user (¬ify, ioc_buf,sizeof (struct smb3_notify_info ))) + goto e_fault; }else { -if (copy_from_user (¬ify, ioc_buf,sizeof (struct smb3_notify ))) { - rc = -EFAULT ; - goto notify_exit; - } +if (copy_from_user (¬ify, ioc_buf,sizeof (struct smb3_notify ))) + goto e_fault; + notify.data_len =0 ; }
@@ -2417,6 +2414,10 @@ smb3_notify(const unsigned int xid, struct file *pfile,free_dentry_path (page);kfree (utf16_path);return rc; + +e_fault: + rc = -EFAULT ; + goto notify_exit; } static int
Signature · 1 line
2.51.0