Skip to contentSkip to conversation

xfs: Delayed logging design documentation

PATCH [email protected] 2 participants 2 messages May 6, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 921460991.88921273119221574.JavaMail.root@mail-au

#1 lore raw

Yo,

Looking good Dave! Thanks for writing this up, it made for some interesting lunch time reading. ;)

Here's a few typos I noticed, marked 'em up as I read along...

Quoted 1 line

+required for objects that are frequently logged. Parts inodes are

"Some parts of ..."?

Quoted 1 line

+The limitation on asynchrnous transaction throughput is the number

"asynchronous"

Quoted 1 line

+Effectively, this gives us the maximum bound out outstanding metadata

"out" -> "of"

Quoted 1 line

+formating the changes in a transaction to the log buffer. Hence we

"formatting"

Quoted 3 lines

+One of the key changes that delayed logging makes to the operation of the
+journalling subsystem is that is dissociates the amount of

"is" -> "it", and "disassociates" (or maybe "dissociates" is what you meant, you chem freak you. ;)

Quoted 1 line

+recovered filesysetm is concerned, there may be many thousands of

filesystem.

Quoted 1 line

+This introduces lots of scope of deadlocks with transactions that are

"scope for deadlocks"?

Quoted 1 line

+The solution is relatively simple - it just a long time to recognise

"took a long time"

Quoted 1 line

+rewrite the vector addresses to point at the memory buffer we end up

"and rewriting the"

Quoted 2 lines

with a
+self-describing object that it can be passed to the log buffer write

"that can be"

Quoted 2 lines

is entire
+arbitrary and done to make it easy for debugging - the last items in

"is entirely"

Quoted 2 lines

+crash during the write of a such a transaction could partially overwrites the

"partially overwrite"

Quoted 1 line

+format structure. That is, two vectors totalling roughly 150 bytes.

"totaling"

Quoted 1 line

+the write reservation (the actual space availble to the transaction)

"available"

Quoted 2 lines

+checkpoint commit to complete. This background push checked and executed by transaction commit code.

"is checked"

Quoted 1 line

+log item completion. THe result of this is that pinning and unpinning

"The"

Quoted 1 line

+are entered and completed is the object considered clean.`

Spurious "`" there?

Review

Quoted 2 lines
(quoted diff) +2 -0
+		=> gain confidence and fix problems reported by early
+		   adopters (a.k.a. guinea pigs)

:-)

cheers.

Signature · 6 lines
Nathan

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
#2 lore raw
Quoted 6 lines · On Thu, May 06, 2010 at 02:17:04PM +1000, [email protected] wrote:

Yo,

Looking good Dave! Thanks for writing this up, it made for some interesting lunch time reading. ;)

Here's a few typos I noticed, marked 'em up as I read along...

Thanks for the proof reading. ;)

I've fixed all the bits you pointed out, and a couple more I found while fixing those....

Cheers,

Dave.

Signature · 7 lines
Dave Chinner
[email protected]

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs