Skip to contentSkip to conversation

gfs2: Delete an unnecessary check before brelse()

PATCH In review Markus Elfring 2 participants 3 messages Sep 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gfs2: Delete an unnecessary check before brelse()

From: Markus Elfring <[email protected]>
Date: Tue, 3 Sep 2019 15:10:05 +0200

The brelse() function tests whether its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

---
 fs/gfs2/dir.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/gfs2/dir.c +1 -2
index 6f35d19eec25..eb9c0578978f 100644
@@ -1463,8 +1463,7 @@ static int gfs2_dir_read_leaf(struct inode *inode, struct dir_context *ctx,
 				sort_offset : entries, copied);
 out_free:
 	for(i = 0; i < leaf; i++)
-		if (larr[i])
-			brelse(larr[i]);
+		brelse(larr[i]);
 	kvfree(larr);
 out:
 	return error;

--
2.23.0

#1 lore raw

Am Di., 3. Sept. 2019 um 15:21 Uhr schrieb Markus Elfring <[email protected]>:

Quoted 8 lines

From: Markus Elfring <[email protected]>
Date: Tue, 3 Sep 2019 15:10:05 +0200

The brelse() function tests whether its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Thanks. The same applies to brelse() in gfs2_dir_no_add (which Coccinelle apparently missed), so let me fix that as well.

Andreas

#2 lore raw
Quoted 8 lines
Quoted 5 lines

The brelse() function tests whether its argument is NULL and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

The same applies to brelse() in gfs2_dir_no_add
(which Coccinelle apparently missed),

Would you like to achieve that such source code analysis will be extended to corresponding header files?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/fs/gfs2/dir.h?id=7dc4585e03786f84d6e9dc16caa3ba5b8b44d986#n33

Quoted 1 line

so let me fix that as well.

Thanks for your positive feedback.

Regards,
Markus