Skip to contentSkip to conversation

Timertop - update

PATCH Daniel Petrini 2 participants 3 messages Aug 8, 2005

lore
Share & tools
lore
#0 lore raw

Hi,

Here we have a slightly update for timertop script, it now shows the ticks in Hz (borrowed from Tony's pmstats - let me know if I shouldn't :-) ) and some cleanups.

The timertop kernel patch is the same, tested for 2.6.13-rc5-dtck-5.patch.

I'm open to suggestions on what to aggregate in that utility.

In my system, a Dell Latitude D600, dyn tick is working ok. IT has 50 ticks in complete desktop environment.

Regards,

Daniel

Signature · 2 lines
10LE - Linux
INdT - Manaus - Brazil
kernel/Makefile +1 -1
diff -uprN linux-2.6.12-orig/kernel/Makefile linux-dyn-tick/kernel/Makefile
@@ -30,7 +30,7 @@ obj-$(CONFIG_SYSFS) += ksysfs.o
 obj-$(CONFIG_GENERIC_HARDIRQS) += irq/
 obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
 obj-$(CONFIG_SECCOMP) += seccomp.o
-obj-$(CONFIG_NO_IDLE_HZ) += dyn-tick.o
+obj-$(CONFIG_NO_IDLE_HZ) += dyn-tick.o timer_top.o
 
 ifneq ($(CONFIG_SCHED_NO_NO_OMIT_FRAME_POINTER),y)
 # According to Alan Modra <[email protected]>, the -fno-omit-frame-pointer is
kernel/timer.c +4 -0
diff -uprN linux-2.6.12-orig/kernel/timer.c linux-dyn-tick/kernel/timer.c
@@ -508,6 +508,9 @@ static inline void __run_timers(tvec_bas
 }
 
 #ifdef CONFIG_NO_IDLE_HZ
+extern struct timer_top_info top_info;
+extern int account_timer(unsigned int function,
+	       		struct timer_top_info * top_info);
 /*
  * Find out when the next timer event is due to happen. This
  * is used on S/390 to stop all activity when a cpus is idle.
@@ -571,6 +574,7 @@ found:
 				expires = nte->expires;
 		}
 	}
+	account_timer((unsigned int)nte->function, &top_info);
 	spin_unlock(&base->t_base.lock);
 	return expires;
 }
kernel/timer_top.c +108 -0

108 lines not on this page · raw message

#1 lore raw
Quoted 6 lines · Daniel Petrini

Hi,

Here we have a slightly update for timertop script, it now shows the ticks in Hz (borrowed from Tony's pmstats - let me know if I shouldn't

:-) ) and some cleanups.

Small comment: I had to move the shell call (#!/usr/bin/perl) to the top of the file before i was able to start it.

One that comes back very often in timertop is:

c0124cf0| 510606| 314.40| process_timeout

Any idea what that is?

Thanks,

Jan

Signature · 1 line
One small step for man, one giant stumble for mankind.
#2 lore raw

Hi,

Quoted 2 lines

Small comment: I had to move the shell call (#!/usr/bin/perl) to the top of the file before i was able to start it.

Ok. I will change that. I was only using "perl timer_top.pl 5"

Quoted 5 lines

One that comes back very often in timertop is:

c0124cf0| 510606| 314.40| process_timeout

Any idea what that is?

This is the timer scheduled by the schedule_timeout function. Some driver is using that instead of a new timer function.

Quoted 3 lines

Thanks,

Jan

Thanks,
Daniel

Signature · 2 lines
10LE - Linux
INdT - Manaus - Brazil