scsi: jazz_esp: add IRQ check
PATCH 1/1 scsi: jazz_esp: add IRQ check
The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to request_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, masking the actual error code. Propagate the negative IRQ error codes upstream instead.
Fixes 352e921f0dd4 ("[SCSI] jazz_esp: converted to use esp_core")
Signed-off-by Sergey Shtylyov <[email protected]>
---
The patch is against the 'fixes' branch of Martin Petersen's 'scsi.git' repo.
drivers/scsi/jazz_esp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/scsi/jazz_esp.c +3 -1
@@ -170,7 +170,9 @@ static int esp_jazz_probe(struct platforif (!esp->command_block) goto fail_unmap_regs; - host->irq =platform_get_irq (dev,0 ); + host->irq = err =platform_get_irq (dev,0 ); +if (err <0 ) + goto fail_unmap_command_block; err =request_irq (host->irq, scsi_esp_intr,IRQF_SHARED ,"ESP" , esp);if (err <0 ) goto fail_unmap_command_block;