Skip to contentSkip to conversation

Questions about openbmc-test-automation

DISCUSSION Tony Lee (李文富) 2 participants 6 messages Nov 5, 2019 – Nov 7, 2019

lore
Share & tools
lore
#0 lore raw

Hi Rahul,

I'm wondering that why "REDFISH_NW_ETH0" is hardcode as "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py
https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155
Furthermore, the command "lan print" didn't specify the channel number in /ipmi/test_ipmi_network.robot. Therefore, the default will print information on the first found LAN channel.

Isn't it more reasonable to set the interface and the channel number as environment variables and give them default values?

Thanks
Best Regards,
Tony

#1 lore raw

Thanks for pointing that out. Passing interface/channel number is an easier option but we should be avoiding passing environment variable unless there is no other way. I would say better way to overcome this is to figure out the channel count using "ip addr" command from BMC cli.
Let us know if that sounds good to you.
Also let us know if you would like to drop code change for the same?

Thanks
Rahul

Quoted 31 lines · Tony Lee (李文富)

Hi Rahul,

I'm wondering that why "REDFISH_NW_ETH0" is hardcode as "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py

https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155

Furthermore, the command "lan print" didn't specify the channel number in /ipmi/test_ipmi_network.robot.

Therefore, the default will print information on the first found LAN channel.

Isn't it more reasonable to set the interface and the channel number as environment variables and give them default values?

Thanks

Best Regards,

Tony

#2 lore raw

Hi Rahul,

For example, case "Retrieve IP Address Via IPMI And Verify Using Redfish" in /ipmi/test_ipmi_network.robot. The new way is as follows:

IPMI network channel logically starts from 1. For example, once it figure out the channel count is 3,
we can retrieve IP addresses through channels 1, 2, and 3, and verify them correspond to eth0, eth1, and eth2, respectively by redfish. Is it right?

Thanks
Best Regards,
Tony

From: Rahul Maheshwari <[email protected]>
Sent: Tuesday, November 5, 2019 6:51 PM
To: Tony Lee (李文富) <[email protected]>
Cc: [email protected]
Subject: Re: Questions about openbmc-test-automation

Thanks for pointing that out. Passing interface/channel number is an easier option but we should be avoiding passing environment variable unless there is no other way. I would say better way to overcome this is to figure out the channel count using "ip addr" command from BMC cli. Let us know if that sounds good to you.
Also let us know if you would like to drop code change for the same?

Thanks
Rahul

On Tue, Nov 5, 2019 at 2:28 PM Tony Lee (李文富) <mailto:[email protected]> wrote:
Hi Rahul,

I'm wondering that why "REDFISH_NW_ETH0" is hardcode as "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py
https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155
Furthermore, the command "lan print" didn't specify the channel number in /ipmi/test_ipmi_network.robot. Therefore, the default will print information on the first found LAN channel.

Isn't it more reasonable to set the interface and the channel number as environment variables and give them default values?
Thanks
Best Regards,
Tony

#3 lore raw

Yes, that is correct way.

Quoted 58 lines · Tony Lee (李文富)

Hi Rahul,

For example, case "Retrieve IP Address Via IPMI And Verify Using Redfish" in /ipmi/test_ipmi_network.robot.
The new way is as follows:

IPMI network channel logically starts from 1. For example, once it figure out the channel count is 3,
we can retrieve IP addresses through channels 1, 2, and 3, and verify them correspond to eth0, eth1, and eth2, respectively by redfish. Is it right?

Thanks
Best Regards,
Tony

From: Rahul Maheshwari <[email protected]>
Sent: Tuesday, November 5, 2019 6:51 PM
To: Tony Lee (李文富) <[email protected]>
Cc: [email protected]
Subject: Re: Questions about openbmc-test-automation

Thanks for pointing that out. Passing interface/channel number is an easier option but we should be avoiding passing environment variable unless there is no other way. I would say better way to overcome this is to figure out the channel count using "ip addr" command from BMC cli.
Let us know if that sounds good to you.
Also let us know if you would like to drop code change for the same?

Thanks
Rahul

On Tue, Nov 5, 2019 at 2:28 PM Tony Lee (李文富) <mailto:
[email protected]> wrote:
Hi Rahul,

I'm wondering that why "REDFISH_NW_ETH0" is hardcode as "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py

https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155
Furthermore, the command "lan print" didn't specify the channel number in /ipmi/test_ipmi_network.robot.
Therefore, the default will print information on the first found LAN channel.

Isn't it more reasonable to set the interface and the channel number as environment variables and give them default values?

Thanks
Best Regards,
Tony

#4 lore raw

Hi Rahul,

It sounds good to me and I would like to drop code change.

From: Rahul Maheshwari <[email protected]>
Sent: Wednesday, November 6, 2019 3:13 PM
To: Tony Lee (李文富) <[email protected]>
Cc: [email protected]
Subject: Re: Questions about openbmc-test-automation

Yes, that is correct way.

On Wed, Nov 6, 2019 at 11:22 AM Tony Lee (李文富) <mailto:[email protected]> wrote:
Hi Rahul,

For example, case "Retrieve IP Address Via IPMI And Verify Using Redfish" in /ipmi/test_ipmi_network.robot. The new way is as follows:

IPMI network channel logically starts from 1. For example, once it figure out the channel count is 3,
we can retrieve IP addresses through channels 1, 2, and 3, and verify them correspond to eth0, eth1, and eth2, respectively by redfish. Is it right?

Thanks
Best Regards,
Tony

From: Rahul Maheshwari <mailto:[email protected]>
Sent: Tuesday, November 5, 2019 6:51 PM
To: Tony Lee (李文富) <mailto:[email protected]>
Cc: mailto:[email protected]
Subject: Re: Questions about openbmc-test-automation

Thanks for pointing that out. Passing interface/channel number is an easier option but we should be avoiding passing environment variable unless there is no other way. I would say better way to overcome this is to figure out the channel count using "ip addr" command from BMC cli. Let us know if that sounds good to you.
Also let us know if you would like to drop code change for the same?

Thanks
Rahul

On Tue, Nov 5, 2019 at 2:28 PM Tony Lee (李文富) <mailto:mailto:[email protected]> wrote:
Hi Rahul,

I'm wondering that why "REDFISH_NW_ETH0" is hardcode as "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py
https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155
Furthermore, the command "lan print" didn't specify the channel number in /ipmi/test_ipmi_network.robot. Therefore, the default will print information on the first found LAN channel.

Isn't it more reasonable to set the interface and the channel number as environment variables and give them default values?
Thanks
Best Regards,
Tony

#5 lore raw

Sure. Thanks for taking up the initiative.

Quoted 72 lines · On Thu, 7 Nov 2019, 07:07 Tony Lee (李文富), <[email protected]> wrote:

Hi Rahul,

It sounds good to me and I would like to drop code change.

From: Rahul Maheshwari <[email protected]>
Sent: Wednesday, November 6, 2019 3:13 PM
To: Tony Lee (李文富) <[email protected]>
Cc: [email protected]
Subject: Re: Questions about openbmc-test-automation

Yes, that is correct way.

On Wed, Nov 6, 2019 at 11:22 AM Tony Lee (李文富) <mailto:
[email protected]> wrote:
Hi Rahul,

For example, case "Retrieve IP Address Via IPMI And Verify Using Redfish" in /ipmi/test_ipmi_network.robot.
The new way is as follows:

IPMI network channel logically starts from 1. For example, once it figure out the channel count is 3,
we can retrieve IP addresses through channels 1, 2, and 3, and verify them correspond to eth0, eth1, and eth2, respectively by redfish. Is it right?

Thanks
Best Regards,
Tony

From: Rahul Maheshwari <mailto:[email protected]>
Sent: Tuesday, November 5, 2019 6:51 PM
To: Tony Lee (李文富) <mailto:[email protected]>
Cc: mailto:[email protected]
Subject: Re: Questions about openbmc-test-automation

Thanks for pointing that out. Passing interface/channel number is an easier option but we should be avoiding passing environment variable unless there is no other way. I would say better way to overcome this is to figure out the channel count using "ip addr" command from BMC cli.
Let us know if that sounds good to you.
Also let us know if you would like to drop code change for the same?

Thanks
Rahul

On Tue, Nov 5, 2019 at 2:28 PM Tony Lee (李文富) <mailto:mailto:
[email protected]> wrote:
Hi Rahul,

I'm wondering that why "REDFISH_NW_ETH0" is hardcode as "Managers/bmc/EthernetInterfaces/eth0/" in /data/variables.py

https://github.com/openbmc/openbmc-test-automation/blob/master/data/variables.py#L155
Furthermore, the command "lan print" didn't specify the channel number in /ipmi/test_ipmi_network.robot.
Therefore, the default will print information on the first found LAN channel.

Isn't it more reasonable to set the interface and the channel number as environment variables and give them default values?

Thanks
Best Regards,
Tony