Skip to contentSkip to conversation

bonding: ARP monitor spams NETDEV_NOTIFY_PEERS notifiers

PATCH Applied Jay Vosburgh 3 participants 3 messages Jun 16, 2022 – Jun 18, 2022

Subsystems (3)
Networking Network drivers Bonding driver
lore
Share & tools
lore

Jay Vosburgh

author
#0 lore raw

PATCH 1/1 bonding: ARP monitor spams NETDEV_NOTIFY_PEERS notifiers

The bonding ARP monitor fails to decrement send_peer_notif, the
number of peer notifications (gratuitous ARP or ND) to be sent. This results in a continuous series of notifications.

Correct this by decrementing the counter for each notification.

Reported-by Jonathan Toppins <[email protected]>
Signed-off-by Jay Vosburgh <[email protected]>
Fixes b0929915e035 ("bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor")
Link https://lore.kernel.org/netdev/[email protected]/ open here
---
 drivers/net/bonding/bond_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +3 -1
index f85372adf042..6ba4c83fe5fc 100644
@@ -3684,9 +3684,11 @@ static void bond_activebackup_arp_mon(struct bonding *bond)
 		if (!rtnl_trylock())
 			return;
 
-		if (should_notify_peers)
+		if (should_notify_peers) {
+			bond->send_peer_notif--;
 			call_netdevice_notifiers(NETDEV_NOTIFY_PEERS,
 						 bond->dev);
+		}
 		if (should_notify_rtnl) {
 			bond_slave_state_notify(bond);
 			bond_slave_link_notify(bond);
Signature · 1 line
2.29.GIT
Tested-by Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Jay Vosburgh

The bonding ARP monitor fails to decrement send_peer_notif, the
number of peer notifications (gratuitous ARP or ND) to be sent. This results in a continuous series of notifications.

Correct this by decrementing the counter for each notification.

Reported-by Jonathan Toppins <[email protected]>
Signed-off-by Jay Vosburgh <[email protected]>
Fixes b0929915e035 ("bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor")
Link https://lore.kernel.org/netdev/[email protected]/ open here

Jay, this works great. Thanks.

Tested-by Jonathan Toppins <[email protected]>
Reviewed-by Jonathan Toppins <[email protected]>
CI Applied
#2 lore raw
In reply to Jay Vosburgh
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 4 lines · On Thu, 16 Jun 2022 12:32:40 -0700 you wrote:

The bonding ARP monitor fails to decrement send_peer_notif, the number of peer notifications (gratuitous ARP or ND) to be sent. This results in a continuous series of notifications.

Quoted 8 lines

Correct this by decrementing the counter for each notification.

Reported-by Jonathan Toppins <[email protected]>
Signed-off-by Jay Vosburgh <[email protected]>
Fixes b0929915e035 ("bonding: Fix RTNL: assertion failed at net/core/rtnetlink.c for ab arp monitor")
Link https://lore.kernel.org/netdev/[email protected]/ open here

[...]

Here is the summary with links:
- [net] bonding: ARP monitor spams NETDEV_NOTIFY_PEERS notifiers

    https://git.kernel.org/netdev/net/c/7a9214f3d88c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html