Fix wrong ID for 28F256P30 in flash.h
PATCH 1/1 Fix wrong ID for 28F256P30 in flash.h
Intel was inconsistent in their device IDs for the P30 Strata NOR. The header flash.h has incorrect device IDs for the top- and bottom-mapped versions of the 32 MB chips as a result. It's an easy mistake to make...
include/flash.h +2 -2
@@ -290,8 +290,8 @@#define INTEL_ID_28F64P30B 0x881A881A/* 64M = 32K x 255 + 32k x 4 */ #define INTEL_ID_28F128P30T 0x88188818/* 128M = 64K x 255 + 32k x 4 */ #define INTEL_ID_28F128P30B 0x881B881B/* 128M = 64K x 255 + 32k x 4 */ -#define INTEL_ID_28F256P30T 0x88198819/* 256M = 128K x 255 + 32k x 4 */ -#define INTEL_ID_28F256P30B 0x881C881C/* 256M = 128K x 255 + 32k x 4 */ +#define INTEL_ID_28F256P30T 0x89198919/* 256M = 128K x 255 + 32k x 4 */ +#define INTEL_ID_28F256P30B 0x891C891C/* 256M = 128K x 255 + 32k x 4 */ #define INTEL_ID_28F160S3 0x00D000D0/* 16M = 512K x 32 (64kB x 32) */ #define INTEL_ID_28F320S3 0x00D400D4/* 32M = 512K x 64 (64kB x 64) */
Signature · 2 lines
View this message in context: http://www.nabble.com/-PATCH--Fix-wrong-ID-for-28F256P30-in-flash.h-tf3397449.html#a9459708 Sent from the Uboot - Users mailing list archive at Nabble.com.
PATCH 1/1 Fix wrong ID for 28F256P30 in flash.h
Quoted 10 lines · Pete MacKay
Intel was inconsistent in their device IDs for the P30 Strata NOR. The header
flash.hhas incorrect device IDs for the top- and bottom-mapped versions of the 32 MB chips as a result. It's an easy mistake to make...
include/flash.h line 297
Quoted 10 lines
include/flash.h +2
-2@@ -290,8 +290,8 @@#define INTEL_ID_28F64P30B 0x881A881A/* 64M = 32K x 255 + 32k x 4 */ #define INTEL_ID_28F128P30T 0x88188818/* 128M = 64K x 255 + 32k x 4 */ #define INTEL_ID_28F128P30B 0x881B881B/* 128M = 64K x 255 + 32k x 4 */ -#define INTEL_ID_28F256P30T 0x88198819/* 256M = 128K x 255 + 32k x 4 */ -#define INTEL_ID_28F256P30B 0x881C881C/* 256M = 128K x 255 + 32k x 4 */ +#define INTEL_ID_28F256P30T 0x89198919/* 256M = 128K x 255 + 32k x 4 */ +#define INTEL_ID_28F256P30B 0x891C891C/* 256M = 128K x 255 + 32k x 4 */ #define INTEL_ID_28F160S3 0x00D000D0/* 16M = 512K x 32 (64kB x 32) */ #define INTEL_ID_28F320S3 0x00D400D4/* 32M = 512K x 64 (64kB x 64) */
Thanks for the update. However, the CFI driver actually does not use these macro.
Is there a place (custom driver) that this ID was used an caused a problem?
I personally actually want to remove these macros for any device that could be serviced by cfi_flash.c driver.
Tolunay
PATCH 1/1 Fix wrong ID for 28F256P30 in flash.h
Quoted 3 lines · In message <[email protected]> you wrote:
I personally actually want to remove these macros for any device that could be serviced by
cfi_flash.cdriver.
That would break all custom drivers that use these; and there are systems that cannot use the CFI driver because of size restrictions.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Where there's no emotion, there's no motive for violence. -- Spock, "Dagger of the Mind", stardate 2715.1
PATCH 1/1 Fix wrong ID for 28F256P30 in flash.h
Quoted 6 lines · Wolfgang Denk
Quoted 3 lines · In message <[email protected]> you wrote:
I personally actually want to remove these macros for any device that could be serviced by
cfi_flash.cdriver.
Quoted 8 lines
That would break all custom drivers that use these; and there are systems that cannot use the CFI driver because of size restrictions.
Best regards,
Wolfgang Denk
Obviously, I would not remove the ones that are in use but I suspect there are some that are not in use after switching to cfi_flash.c.
I think for new flash that is cfi compliant and could be serviced by cfi_flash.c there is no reason to define these macros.
Whenever I have some time, I actually want to improve cfi_flash.c to handle non-cfi flash as well. It will use jedec ids stored in a table so these macros would not be much useful.
Best regards,
Tolunay
PATCH 1/1 Fix wrong ID for 28F256P30 in flash.h
Quoted 2 lines · Tolunay Orkun
Obviously, I would not remove the ones that are in use but I suspect there are some that are not in use after switching to
cfi_flash.c.
Sure.
Quoted 6 lines
I think for new flash that is cfi compliant and could be serviced by
cfi_flash.cthere is no reason to define these macros.Whenever I have some time, I actually want to improve
cfi_flash.cto handle non-cfi flash as well. It will use jedec ids stored in a table so these macros would not be much useful.
/me crosses his fingers that Tolunay soon will have "some time". ;-)
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
=====================================================================