Skip to contentSkip to conversation

drm/amdkfd: Delete an error message for a failed memory allocation in kfd_topology_init()

PATCH In review SF Markus Elfring 2 participants 2 messages Feb 8, 2018 – Feb 25, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdkfd: Delete an error message for a failed memory allocation in kfd_topology_init()

From: Markus Elfring <[email protected]>
Date: Thu, 8 Feb 2018 22:23:57 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

---
 drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_topology.c +0 -1
index 19ce59028d6b..610e3d4ac575 100644
@@ -1019,7 +1019,6 @@ int kfd_topology_init(void)
 		crat_image = kmalloc(image_size, GFP_KERNEL);
 		if (!crat_image) {
 			ret = -ENOMEM;
-			pr_err("No memory for allocating CRAT image\n");
 			goto err;
 		}
 		ret = kfd_topology_get_crat_acpi(crat_image, &image_size);
Signature · 6 lines
2.16.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw
Quoted 25 lines · SF Markus Elfring

From: Markus Elfring <[email protected]>
Date: Thu, 8 Feb 2018 22:23:57 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

---
 drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_topology.c +0 -2
index 19ce59028d6b..610e3d4ac575 100644
@@ -1019,7 +1019,6 @@ int kfd_topology_init(void)
                crat_image = kmalloc(image_size, GFP_KERNEL);
                if (!crat_image) {
                        ret = -ENOMEM;
-                       pr_err("No memory for allocating CRAT image\n");
                        goto err;
                }
                ret = kfd_topology_get_crat_acpi(crat_image, &image_size);
--
Quoted 2 lines

2.16.1

Hi,
Thanks for the patch but this code block is going to be refactored in the next merge window and the patch will no longer be relevant.

Oded
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx