Skip to contentSkip to conversation

Clarify some questions about BIOS update (phosphor-ipmi-flash)

DISCUSSION Andrew MS1 Peng 2 participants 10 messages Aug 5, 2019 – Aug 8, 2019

lore
Share & tools
lore
#0 lore raw

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".
2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

Regards,
Andrew

#1 lore raw
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a null-string:

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df2514927e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#2 lore raw
Quoted 24 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 8 lines
Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a null-string:

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df2514927e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

Quoted 14 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#3 lore raw
Quoted 33 lines · Patrick Venture
Quoted 31 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a null-string:

Quoted 4 lines
Quoted 1 line

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df2514927e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

First patch in the series generated from your email:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/24165

Next: json configuration option to control the job-mode. Then merge verification and update objects, s.t. you can specify the status path.

*** A later patchset can have the status be not a path, but a dbus property or dbus path -- if someone wants to implement a new object for this, it's somewhat trivial.

Quoted 15 lines
Quoted 15 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#4 lore raw
Quoted 23 lines · Patrick Venture
Quoted 21 lines · Patrick Venture
Quoted 19 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

This patch will enable you to specify "mode" in the json. *** note: i will set some time aside shortly to document writing json configurations.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/24167

Quoted 38 lines
Quoted 10 lines
Quoted 7 lines

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a null-string:

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df2514927e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

First patch in the series generated from your email:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/24165

Next: json configuration option to control the job-mode. Then merge verification and update objects, s.t. you can specify the status path.

*** A later patchset can have the status be not a path, but a dbus property or dbus path -- if someone wants to implement a new object for this, it's somewhat trivial.

Quoted 15 lines
Quoted 15 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#5 lore raw
Quoted 30 lines · Patrick Venture
Quoted 28 lines · Patrick Venture
Quoted 26 lines · Patrick Venture
Quoted 24 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 26 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

This patch will enable you to specify "mode" in the json. *** note: i will set some time aside shortly to document writing json configurations.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/24167

Quoted 18 lines
Quoted 10 lines
Quoted 7 lines

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a null-string:

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df2514927e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

First patch in the series generated from your email:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/24165

Next: json configuration option to control the job-mode. Then merge verification and update objects, s.t. you can specify the status path.

This patchset adds support for a new update configuration that lets you read the status from a file.

https://gerrit.openbmc-project.xyz/24171

Quoted 20 lines
Quoted 20 lines

*** A later patchset can have the status be not a path, but a dbus property or dbus path -- if someone wants to implement a new object for this, it's somewhat trivial.

Quoted 15 lines
Quoted 15 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#6 lore raw

Hi Patrick,

The triggered "phosphor-ipmi-flash-bios-update.target" seems to been solved, but the BIOS update status has not yet been fixed.
Could we add checking the contents of the file in SystemdUpdateMechanism::status() function of update_systemd.cpp such as verification mechanism SystemdWithStatusFile::status() of general_systemd.cpp?

Regards,
Andrew

-----邮件原件-----
发件人: Patrick Venture <[email protected]>
发送时间: 2019年8月6日 4:39
收件人: Andrew MS1 Peng <[email protected]>
抄送: [email protected]; Duke KH Du <[email protected]>; Yonghui YH21 Liu <[email protected]>; Lisa YJ19 Liu <[email protected]> 主题: [External] Re: Clarify some questions about BIOS update (phosphor-ipmi-flash)

Quoted 31 lines · Patrick Venture
Quoted 29 lines · Patrick Venture
Quoted 27 lines · Patrick Venture
Quoted 25 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 30 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

This patch will enable you to specify "mode" in the json. *** note: i will set some time aside shortly to document writing json configurations.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/241
67

Quoted 21 lines
Quoted 7 lines
Quoted 7 lines

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a
null-string:

Quoted 5 lines
Quoted 2 lines

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df25149
27e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

First patch in the series generated from your email:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/2
4165

Next: json configuration option to control the job-mode. Then merge verification and update objects, s.t. you can specify the status path.

This patchset adds support for a new update configuration that lets you read the status from a file.

https://gerrit.openbmc-project.xyz/24171

Quoted 20 lines
Quoted 20 lines

*** A later patchset can have the status be not a path, but a dbus property or dbus path -- if someone wants to implement a new object for this, it's somewhat trivial.

Quoted 15 lines
Quoted 15 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#7 lore raw
Quoted 5 lines · On Wed, Aug 7, 2019 at 4:47 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

The triggered "phosphor-ipmi-flash-bios-update.target" seems to been solved, but the BIOS update status has not yet been fixed.
Could we add checking the contents of the file in SystemdUpdateMechanism::status() function of update_systemd.cpp such as verification mechanism SystemdWithStatusFile::status() of general_systemd.cpp?

You can just use the type "fileSystemdUpdate" which let you check a path for the status.

The three parameters for that update type are the same as the verification type that matches:
- path - the filesystem path containing the status
- unit - the target "phosphor-ipmi-flash-bios-update.target"
- mode - optional job-mode parameter, defaults to "replace"

Quoted 98 lines

Regards,
Andrew

-----邮件原件-----
发件人: Patrick Venture <[email protected]>
发送时间: 2019年8月6日 4:39
收件人: Andrew MS1 Peng <[email protected]>
抄送: [email protected]; Duke KH Du <[email protected]>; Yonghui YH21 Liu <[email protected]>; Lisa YJ19 Liu <[email protected]> 主题: [External] Re: Clarify some questions about BIOS update (phosphor-ipmi-flash)

Quoted 31 lines · Patrick Venture
Quoted 29 lines · Patrick Venture
Quoted 27 lines · Patrick Venture
Quoted 25 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 30 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

This patch will enable you to specify "mode" in the json. *** note: i will set some time aside shortly to document writing json configurations.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/241
67

Quoted 21 lines
Quoted 7 lines
Quoted 7 lines

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a
null-string:

Quoted 5 lines
Quoted 2 lines

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df25149
27e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

First patch in the series generated from your email:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/2
4165

Next: json configuration option to control the job-mode. Then merge verification and update objects, s.t. you can specify the status path.

This patchset adds support for a new update configuration that lets you read the status from a file.

https://gerrit.openbmc-project.xyz/24171

Quoted 20 lines
Quoted 20 lines

*** A later patchset can have the status be not a path, but a dbus property or dbus path -- if someone wants to implement a new object for this, it's somewhat trivial.

Quoted 15 lines
Quoted 15 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#8 lore raw

Hi Patrick,

1. Following your suggestion to modify the json file, but encountered an error message as "Parsing json failed ". Please help to take a look at it, thanks.

	A part of config-bios.json(default) content and journalctl log was below. 
		"update": {
			"type": "systemd",
			"unit": "phosphor-ipmi-flash-bios-update.target"
		}
        
        Aug 07 06:54:22 hr630 ipmid[507]: Registering OEM:[0X00C2CF], Cmd:[0X80] for Blob Commands
        Aug 07 06:54:22 hr630 ipmid[507]: config loaded: /flash/bios
        Aug 07 06:54:22 hr630 ipmid[507]: config loaded: /flash/image


	A part of config-bios.json(modification) content and journalctl log was below. 
		"update": {
			"type": "fileSystemdUpdate",
			"unit": "phosphor-ipmi-flash-bios-update.target"
			"path": "/tmp/bios.update"
		}

        Aug 07 06:33:12 hr630 ipmid[498]: Registering OEM:[0X00C2CF], Cmd:[0X80] for Blob Commands
        Aug 07 06:33:12 hr630 ipmid[498]: Parsing json failed
        Aug 07 06:33:12 hr630 ipmid[498]: config loaded: /flash/image

2. Which one is the best way to modify json file in OpenBmc, patch or overwrite? I added lenovo-bios-update.bb to handle service and script. I encountered an error message as "file conflicts" when I added new file of json to overwrite original file. What should I do to fix it?

		The error message is below.
			Error: Transaction check error:
			file /usr/share/phosphor-ipmi-flash/config-bios.json conflicts between attempted installs of phosphor-ipmi-flash-1.0+git999-r1.armv6 and lenovo-bios-update-1.0-r0.armv6 

		A part of lenovo-bios-update.bb content is below.
			SRC_URI += " \
			file://bios-verify.service \
            file://bios-verify.sh \
            file://bios-update.service \
            file://bios-update.sh \
            file://config-bios.json \
            "
			DEPENDS += "systemd"
			RDEPENDS_${PN} = "bash"
			SYSTEMD_PACKAGES = "${PN}"
			SYSTEMD_SERVICE_${PN} = "bios-verify.service bios-update.service"
			do_install() {
    			install -d ${D}/usr/sbin
    			install -d ${D}/usr/share/phosphor-ipmi-flash/
    			install -m 0755 ${S}bios-verify.sh ${D}/${sbindir}/
   				install -m 0755 ${S}bios-update.sh ${D}/${sbindir}/
    			install -m 0644 ${S}config-bios.json ${D}/usr/share/phosphor-ipmi-flash/
			}
			FILES_${PN} = " \
    			/usr/share/phosphor-ipmi-flash/config-bios.json \
    			${sbindir}/bios-update.sh \
    			${sbindir}/bios-verify.sh \
    		"

Regards,
Andrew

-----邮件原件-----
发件人: Patrick Venture <[email protected]>
发送时间: 2019年8月7日 23:36
收件人: Andrew MS1 Peng <[email protected]>
抄送: [email protected]
主题: Re: [External] Re: Clarify some questions about BIOS update (phosphor-ipmi-flash)

Quoted 5 lines · On Wed, Aug 7, 2019 at 4:47 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

The triggered "phosphor-ipmi-flash-bios-update.target" seems to been solved, but the BIOS update status has not yet been fixed.
Could we add checking the contents of the file in SystemdUpdateMechanism::status() function of update_systemd.cpp such as verification mechanism SystemdWithStatusFile::status() of general_systemd.cpp?

You can just use the type "fileSystemdUpdate" which let you check a path for the status.

The three parameters for that update type are the same as the verification type that matches:
- path - the filesystem path containing the status
- unit - the target "phosphor-ipmi-flash-bios-update.target"
- mode - optional job-mode parameter, defaults to "replace"

Quoted 103 lines

Regards,
Andrew

-----邮件原件-----
发件人: Patrick Venture <[email protected]>
发送时间: 2019年8月6日 4:39
收件人: Andrew MS1 Peng <[email protected]>
抄送: [email protected]; Duke KH Du <[email protected]>; Yonghui YH21 Liu <[email protected]>; Lisa YJ19 Liu <[email protected]> 主题: [External] Re: Clarify some questions about BIOS update (phosphor-ipmi-flash)

Quoted 33 lines · Patrick Venture
Quoted 24 lines · Patrick Venture
Quoted 22 lines · Patrick Venture
Quoted 20 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

Quoted 31 lines

This patch will enable you to specify "mode" in the json. *** note:
i will set some time aside shortly to document writing json configurations.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/2
41
67

Quoted 23 lines
Quoted 7 lines
Quoted 7 lines

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a
null-string:

Quoted 6 lines
Quoted 3 lines

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df251
49 27e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

First patch in the series generated from your email:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+
/2
4165

Next: json configuration option to control the job-mode. Then merge verification and update objects, s.t. you can specify the status path.

This patchset adds support for a new update configuration that lets you read the status from a file.

https://gerrit.openbmc-project.xyz/24171

Quoted 20 lines
Quoted 20 lines

*** A later patchset can have the status be not a path, but a dbus property or dbus path -- if someone wants to implement a new object for this, it's somewhat trivial.

Quoted 15 lines
Quoted 15 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew

#9 lore raw
Quoted 183 lines · On Thu, Aug 8, 2019 at 1:21 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

1. Following your suggestion to modify the json file, but encountered an error message as "Parsing json failed ". Please help to take a look at it, thanks.

        A part of config-bios.json(default) content and journalctl log was below.
                "update": {
                        "type": "systemd",
                        "unit": "phosphor-ipmi-flash-bios-update.target"
                }

        Aug 07 06:54:22 hr630 ipmid[507]: Registering OEM:[0X00C2CF], Cmd:[0X80] for Blob Commands
        Aug 07 06:54:22 hr630 ipmid[507]: config loaded: /flash/bios
        Aug 07 06:54:22 hr630 ipmid[507]: config loaded: /flash/image


        A part of config-bios.json(modification) content and journalctl log was below.
                "update": {
                        "type": "fileSystemdUpdate",
                        "unit": "phosphor-ipmi-flash-bios-update.target" <--- missing comma.
                        "path": "/tmp/bios.update"
                }

        Aug 07 06:33:12 hr630 ipmid[498]: Registering OEM:[0X00C2CF], Cmd:[0X80] for Blob Commands
        Aug 07 06:33:12 hr630 ipmid[498]: Parsing json failed
        Aug 07 06:33:12 hr630 ipmid[498]: config loaded: /flash/image

2. Which one is the best way to modify json file in OpenBmc, patch or overwrite? I added lenovo-bios-update.bb to handle service and script. I encountered an error message as "file conflicts" when I added new file of json to overwrite original file. What should I do to fix it?

                The error message is below.
                        Error: Transaction check error:
                        file /usr/share/phosphor-ipmi-flash/config-bios.json conflicts between attempted installs of phosphor-ipmi-flash-1.0+git999-r1.armv6 and lenovo-bios-update-1.0-r0.armv6

                A part of lenovo-bios-update.bb content is below.
                        SRC_URI += " \
                        file://bios-verify.service \
            file://bios-verify.sh \
            file://bios-update.service \
            file://bios-update.sh \
            file://config-bios.json \
            "
                        DEPENDS += "systemd"
                        RDEPENDS_${PN} = "bash"
                        SYSTEMD_PACKAGES = "${PN}"
                        SYSTEMD_SERVICE_${PN} = "bios-verify.service bios-update.service"
                        do_install() {
                        install -d ${D}/usr/sbin
                        install -d ${D}/usr/share/phosphor-ipmi-flash/
                        install -m 0755 ${S}bios-verify.sh ${D}/${sbindir}/
                                install -m 0755 ${S}bios-update.sh ${D}/${sbindir}/
                        install -m 0644 ${S}config-bios.json ${D}/usr/share/phosphor-ipmi-flash/
                        }
                        FILES_${PN} = " \
                        /usr/share/phosphor-ipmi-flash/config-bios.json \
                        ${sbindir}/bios-update.sh \
                        ${sbindir}/bios-verify.sh \
                "

Regards,
Andrew

-----邮件原件-----
发件人: Patrick Venture <[email protected]>
发送时间: 2019年8月7日 23:36
收件人: Andrew MS1 Peng <[email protected]>
抄送: [email protected]
主题: Re: [External] Re: Clarify some questions about BIOS update (phosphor-ipmi-flash)

Quoted 5 lines · On Wed, Aug 7, 2019 at 4:47 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

The triggered "phosphor-ipmi-flash-bios-update.target" seems to been solved, but the BIOS update status has not yet been fixed.
Could we add checking the contents of the file in SystemdUpdateMechanism::status() function of update_systemd.cpp such as verification mechanism SystemdWithStatusFile::status() of general_systemd.cpp?

You can just use the type "fileSystemdUpdate" which let you check a path for the status.

The three parameters for that update type are the same as the verification type that matches:
- path - the filesystem path containing the status
- unit - the target "phosphor-ipmi-flash-bios-update.target"
- mode - optional job-mode parameter, defaults to "replace"

Quoted 103 lines

Regards,
Andrew

-----邮件原件-----
发件人: Patrick Venture <[email protected]>
发送时间: 2019年8月6日 4:39
收件人: Andrew MS1 Peng <[email protected]>
抄送: [email protected]; Duke KH Du <[email protected]>; Yonghui YH21 Liu <[email protected]>; Lisa YJ19 Liu <[email protected]> 主题: [External] Re: Clarify some questions about BIOS update (phosphor-ipmi-flash)

Quoted 33 lines · Patrick Venture
Quoted 24 lines · Patrick Venture
Quoted 22 lines · Patrick Venture
Quoted 20 lines · Patrick Venture
Quoted 9 lines · On Mon, Aug 5, 2019 at 4:56 AM Andrew MS1 Peng <[email protected]> wrote:

Hi Patrick,

I have some questions about BIOS update via phosphor-ipmi-flash with L2A, please help to clarify. Thanks.

Thanks for giving it a shot! I don't have any systems using this for BIOS update, so I'm curious where there may be issues lurking :)

Quoted 2 lines

1. How can I update the status (success or failure) after upgrade BIOS firmware? Currently, the update status only appear "running".

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

I see, the update mechanism doesn't have a verification option. A bit of an oversight. I'll have something up for review later today. Then it'll be something you configure similarly to the verifySystemd json entry.

Quoted 1 line

2. It was failed when triggered "phosphor-ipmi-flash-bios-update.target" since the job-mode is null string. It can work well when I add string "replace" to job-mode. How can I config (json file or configure parameter) to support it?

Quoted 31 lines

This patch will enable you to specify "mode" in the json. *** note:
i will set some time aside shortly to document writing json configurations.

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+/2
41
67

Quoted 23 lines
Quoted 7 lines
Quoted 7 lines

I'll take a look! The parameter for job-mode, I thought, was optional? Since we don't specify it for other jobs (verification, etc). The string should be empty by default and then not added as a
null-string:

Quoted 6 lines
Quoted 3 lines

https://github.com/openbmc/phosphor-ipmi-flash/blob/f0c71df251
49 27e933f6fc33d9669ab0663a0706/bmc/update_systemd.cpp#L49

I see it is required! Since I always configure with reboot, I never saw this failure. I'll default it to "replace"

First patch in the series generated from your email:

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-ipmi-flash/+
/2
4165

Next: json configuration option to control the job-mode. Then merge verification and update objects, s.t. you can specify the status path.

This patchset adds support for a new update configuration that lets you read the status from a file.

https://gerrit.openbmc-project.xyz/24171

Quoted 20 lines
Quoted 20 lines

*** A later patchset can have the status be not a path, but a dbus property or dbus path -- if someone wants to implement a new object for this, it's somewhat trivial.

Quoted 15 lines
Quoted 15 lines

I don't think I have a unit-test that verifies the parameters are sent down properly, so I'll also add that today AND I'll add an optional mode parameter to the json.

Sending for review today.

...

Quoted 5 lines

Regards,
Andrew