Skip to contentSkip to conversation

New large block-device patch for 2.5.31+bk

DISCUSSION Peter Chubb 1 participant 1 message Aug 22, 2002 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" == Christoph Hellwig <[email protected]> writes:

Christoph> I don't have much comments left :) What about moving the Christoph> sector_t typedef completly to <asm/types.h>? Looks like Christoph> the cleanest solution to me.

I'd rather not, because most of the architectures just need the generic version. I *hate* unnecessarily duplicated code.

Christoph> I also wonder whether CONFIG_LBD might want to move to Christoph> arch/*/config.

I thought about that, but couldn't work out any way to make it appear in the right place in the menus --- it's really a block device configuration option that happens to be needed only for a few architectures.

Christoph> An a little suggestion: you could feed that patch to Linus Christoph> in pieces. The printk cleanups might be a good start.

Will do...

--
Dr Peter Chubb [email protected]
You are lost in a maze of BitKeeper repositories, all almost the same.