fix: systematically set the logger level to prevent unexpected level inheritance
PATCH v2 1/1 fix: systematically set the logger level to prevent unexpected level inheritance
In reply to a message not in the archiveBSF or other jars can ship with log4j.properties file embedded. This causes problem when launching an application with a general class path (e.g /usr/share/java/*) since log4j will look for a configuration file in all loaded jars. If any contains directive for the root logger it will affect any logger with no level who are directly under the root logger. This could result in an unexpected behaviour (e.g no events triggered et.).
--- tests/regression/ust/java-log4j/JTestLTTng.java | 13 +++++++++++++ 1 file changed, 13 insertions(+)
tests/regression/ust/java-log4j/JTestLTTng.java +13 -0
@@ -23,6 +23,7 @@ import java.lang.Integer; import org.apache.log4j.Appender; import org.apache.log4j.BasicConfigurator; import org.apache.log4j.Logger; +import org.apache.log4j.Level; import org.lttng.ust.agent.log4j.LttngLogAppender; public class JTestLTTng {
@@ -40,6 +41,18 @@ public class JTestLTTng { Logger lttng = Logger.getLogger("log4j-event"); Logger lttng2 = Logger.getLogger("log4j-event-2"); + /* + * Set lowest level to make sure all event levels are logged. + * Any jar can override the default log4j rootLogger level + * and a logger with no explicit level defaults to the non-null + * parent level. Events could be ignored if the inherited value + * is to low. + * e.g BSF -> https://issues.apache.org/jira/browse/BSF-24 + */ + + lttng.setLevel(Level.ALL); + lttng2.setLevel(Level.ALL); + int nrIter = Integer.parseInt(args[0]); int waitTime = Integer.parseInt(args[1]); int fire_debug_tp = 0;
Signature · 6 lines
2.7.4 _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Good catch! Merged in master, stable-2.8 and stable-2.7.
Thanks!
Jérémie
Quoted 48 lines · Jonathan Rajotte
BSF or other jars can ship with log4j.properties file embedded. This causes problem when launching an application with a general class path (e.g
/usr/share/java/*) since log4j will look for a configuration file in all loaded jars. If any contains directive for the root logger it will affect any logger with no level who are directly under the root logger. This could result in an unexpected behaviour (e.g no events triggered et.).Signed-off-by Jonathan Rajotte <[email protected]>--- tests/regression/ust/java-log4j/JTestLTTng.java | 13 +++++++++++++ 1 file changed, 13 insertions(+)tests/regression/ust/java-log4j/JTestLTTng.java +13
-1@@ -23,6 +23,7 @@ import java.lang.Integer; import org.apache.log4j.Appender; import org.apache.log4j.BasicConfigurator; import org.apache.log4j.Logger; +import org.apache.log4j.Level; import org.lttng.ust.agent.log4j.LttngLogAppender; public class JTestLTTng {@@ -40,6 +41,18 @@ public class JTestLTTng { Logger lttng = Logger.getLogger("log4j-event"); Logger lttng2 = Logger.getLogger("log4j-event-2"); + /* + * Set lowest level to make sure all event levels are logged. + * Any jar can override the default log4j rootLogger level + * and a logger with no explicit level defaults to the non-null + * parent level. Events could be ignored if the inherited value + * is to low. + * e.g BSF -> https://issues.apache.org/jira/browse/BSF-24 + */ + + lttng.setLevel(Level.ALL); + lttng2.setLevel(Level.ALL); + int nrIter = Integer.parseInt(args[0]); int waitTime = Integer.parseInt(args[1]); int fire_debug_tp = 0; --2.7.4
Signature · 7 lines
Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev