Skip to contentSkip to conversation

hpsa: SCSI driver for HP Smart Array controllers

DISCUSSION Stephen Cameron 2 participants 2 messages Feb 28, 2009 – Mar 2, 2009

lore
Share & tools
lore
#0 lore raw

I see we botched this in hpsa_pci_init()
(one of the last things we changed):

+ if (prod_index == ARRAY_SIZE(products)) {
+ prod_index--;
+ if (subsystem_vendor_id == !PCI_VENDOR_ID_HP ||
+ !allow_unknown_smartarray) {
+ printk(KERN_WARNING "hpsa: Sorry, I don't "
+ "know how to access the Smart "
+ "Array controller %08lx\n",

That 2nd if should have been,

if (subsystem_vendor_id != PCI_VENDOR_ID_HP ||

-- steve

#1 lore raw

crap

Quoted 30 lines

-----Original Message-----
From: Stephen Cameron [mailto:[email protected]]
Sent: Friday, February 27, 2009 8:59 PM
To: [email protected]
Cc: [email protected]; Miller, Mike (OS Dev)
Subject: Re: hpsa: SCSI driver for HP Smart Array controllers

I see we botched this in hpsa_pci_init() (one of the last things we changed):

(quoted diff) +7 -0
+       if (prod_index == ARRAY_SIZE(products)) {
+               prod_index--;
+               if (subsystem_vendor_id == !PCI_VENDOR_ID_HP ||
+                               !allow_unknown_smartarray) {
+                       printk(KERN_WARNING "hpsa: Sorry, I don't "
+                               "know how to access the Smart "
+                               "Array controller %08lx\n",

That 2nd if should have been,

if (subsystem_vendor_id != PCI_VENDOR_ID_HP ||

-- steve