Skip to contentSkip to conversation

x86/Intel: insert Tiger Lake model numbers

PATCH In review Jan Beulich 2 participants 2 messages Dec 21, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/Intel: insert Tiger Lake model numbers

Both match prior generation processors as far as LBR and C-state MSRs go (SDM rev 073). The if_pschange_mc erratum, according to the spec update, is not applicable.

xen/arch/x86/acpi/cpu_idle.c +3 -0
@@ -183,6 +183,9 @@ static void do_get_hw_residencies(void *
     /* Ice Lake */
     case 0x7D:
     case 0x7E:
+    /* Tiger Lake */
+    case 0x8C:
+    case 0x8D:
     /* Kaby Lake */
     case 0x8E:
     case 0x9E:
xen/arch/x86/hvm/vmx/vmx.c +8 -0
@@ -2436,6 +2436,12 @@ static bool __init has_if_pschange_mc(vo
         return true;
 
         /*
+         * Newer Core processors are not vulnerable.
+         */
+    case 0x8c: /* Tiger Lake */
+    case 0x8d: /* Tiger Lake */
+
+        /*
          * Atom processors are not vulnerable.
          */
     case 0x1c: /* Pineview */
@@ -2776,6 +2782,8 @@ static const struct lbr_info *last_branc
         case 0x7a:
         /* Ice Lake */
         case 0x7d: case 0x7e:
+        /* Tiger Lake */
+        case 0x8c: case 0x8d:
         /* Tremont */
         case 0x86:
         /* Kaby Lake */
#1 lore raw
Quoted 21 lines · Jan Beulich

Both match prior generation processors as far as LBR and C-state MSRs go (SDM rev 073). The if_pschange_mc erratum, according to the spec update, is not applicable.

xen/arch/x86/acpi/cpu_idle.c +3 -0
@@ -183,6 +183,9 @@ static void do_get_hw_residencies(void *
     /* Ice Lake */
     case 0x7D:
     case 0x7E:
+    /* Tiger Lake */
+    case 0x8C:
+    case 0x8D:
     /* Kaby Lake */
     case 0x8E:
     case 0x9E:

xen/arch/x86/hvm/vmx/vmx.c static bool __init has_if_pschange_mc(vo · line 2443

Quoted 8 lines
xen/arch/x86/hvm/vmx/vmx.c +5 -0
@@ -2436,6 +2436,12 @@ static bool __init has_if_pschange_mc(vo
         return true;
 
         /*
+         * Newer Core processors are not vulnerable.
+         */
+    case 0x8c: /* Tiger Lake */
+    case 0x8d: /* Tiger Lake */
+

This hunk should be dropped.  TGL should enumerate ARCH_CAPS_IF_PSCHANGE_MC_NO and take the early exit path.

If it doesn't, we need to know (i.e. hitting the default case), and I'll do even more pestering to have ucode fixed.

Others Acked-by: Andrew Cooper <[email protected]>

Quoted 13 lines
xen/arch/x86/hvm/vmx/vmx.c +3 -0
+        /*
          * Atom processors are not vulnerable.
          */
     case 0x1c: /* Pineview */
@@ -2776,6 +2782,8 @@ static const struct lbr_info *last_branc
         case 0x7a:
         /* Ice Lake */
         case 0x7d: case 0x7e:
+        /* Tiger Lake */
+        case 0x8c: case 0x8d:
         /* Tremont */
         case 0x86:
         /* Kaby Lake */