13023c33c9: kernel-selftests.memory-hotplug.mem-on-off-test.sh.fail
Hi!
Quoted 96 lines
Hi!
Quoted 9 lines
Hi Gongyi,
We noticed that below commit may change the exit status of memory-hotplug selftest, please check if the test result is expected.
We got same test log before this commit but with a good exit, though there were also some "Invalid argument" and "unexpected success" log. Please help give some guidance if there are any problems in our test
flow.
Quoted 28 lines
Thanks.
Greeting,
FYI, we noticed kernel-selftests.memory-hotplug.mem-on-off-test.sh.fail due to commit (built with gcc-11):
commit:
13023c33c962730a38d6b43995910c8805637a9a("selftests/memory-hotplug: Add checking after online or offline")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git masterin testcase: kernel-selftests
version: kernel-selftests-x86_64-9313ba54-1_20221017 with following parameters:group: memory-hotplug
test-description: The kernel contains a set of "self tests" under the
tools/testing/selftests/directory. These are intended to be small unit tests to exercise individual code paths in the kernel.
test-url: https://www.kernel.org/doc/Documentation/kselftest.txton test machine: 8 threads Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (Skylake) with 28G memory
Quoted 7 lines
caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
2022-10-28 01:04:44 make quicktest=1 run_tests -C memory-hotplugmake: Entering directory
'
/usr/src/perf_selftests-x86_64-rhel-8.3-kselftests-13023c33c962730a38Quoted 15 lines
d6b43995910c8805637a9a/tools/testing/selftests/memory-hotplug' TAP version 13
1..1
# selftests: memory-hotplug:mem-on-off-test.sh# Test scope: 2% hotplug memory
# online all hot-pluggable memory in offline state:
# SKIPPED - no hot-pluggable memory in offline state
# offline 2% hot-pluggable memory in online state
# trying to offline 5 out of 224 memory block(s):
#online->offlinememory0
# ./mem-on-off-test.sh: line 78: echo: write error: Invalid argument #offline_memory_expect_success0: unexpected fail #online->offlinememory1 #online->offlinememory10 #online->offlinememory100 #online->offlinememory101 #online->offlinememory102
# online all hot-pluggable memory in offline state:Quoted 8 lines
#
offline->onlinememory1
#offline->onlinememory10
#offline->onlinememory100
#offline->onlinememory101
#offline->onlinememory102
# Test with memory notifier error injection
# ./mem-on-off-test.sh: line 267: echo: write error: Invalid argument #I can not reproduce the error according to the file 'reproduce'.
Line 267 is not runnable on my system. Is there something wrong here?
The code on my system like:
266 #
267 # Offline $ratio percent of hot-pluggable memory 268 #
269 echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error 270 for memory inhotpluggable_online_memory; do
271 if [ $((RANDOM % 100)) -lt $ratio ]; then
272offline_memory_expect_success$memory
&>/dev/null
273 fi
274 doneQuoted 3 lines
online_memory_expect_fail142: unexpected success #online_memory_expect_fail190: unexpected success # ./mem-on-off-test.sh: line 287: echo: write error: Invalid argument #
Quoted 5 lines
The problem is similar with line 267.
Quoted 1 line
offline_memory_expect_fail107: unexpected success #It seems the error-inject not work.
Oh, I see that the version you run the test is based on commit 13023c33c962730a38d6b43995910c8805637a9a, and there is a bug on lib/notifier-error-inject.c.
The commit of the fix patch is c597d9054b13.
Your test version has no the fix patch, So the test failed as expected
Regards,
Gongyi
Hi Gongyi,
Quoted 103 lines · zhaogongyi
Hi!
Quoted 100 lines
Hi!
Quoted 9 lines
Hi Gongyi,
We noticed that below commit may change the exit status of memory-hotplug selftest, please check if the test result is expected.
We got same test log before this commit but with a good exit, though there were also some "Invalid argument" and "unexpected success" log. Please help give some guidance if there are any problems in our test
flow.
Quoted 28 lines
Thanks.
Greeting,
FYI, we noticed kernel-selftests.memory-hotplug.mem-on-off-test.sh.fail due to commit (built with gcc-11):
commit:
13023c33c962730a38d6b43995910c8805637a9a("selftests/memory-hotplug: Add checking after online or offline")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git masterin testcase: kernel-selftests
version: kernel-selftests-x86_64-9313ba54-1_20221017 with following parameters:group: memory-hotplug
test-description: The kernel contains a set of "self tests" under the
tools/testing/selftests/directory. These are intended to be small unit tests to exercise individual code paths in the kernel.
test-url: https://www.kernel.org/doc/Documentation/kselftest.txton test machine: 8 threads Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (Skylake) with 28G memory
Quoted 7 lines
caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
2022-10-28 01:04:44 make quicktest=1 run_tests -C memory-hotplugmake: Entering directory
'
/usr/src/perf_selftests-x86_64-rhel-8.3-kselftests-13023c33c962730a38Quoted 15 lines
d6b43995910c8805637a9a/tools/testing/selftests/memory-hotplug' TAP version 13
1..1
# selftests: memory-hotplug:mem-on-off-test.sh# Test scope: 2% hotplug memory
# online all hot-pluggable memory in offline state:
# SKIPPED - no hot-pluggable memory in offline state
# offline 2% hot-pluggable memory in online state
# trying to offline 5 out of 224 memory block(s):
#online->offlinememory0
# ./mem-on-off-test.sh: line 78: echo: write error: Invalid argument #offline_memory_expect_success0: unexpected fail #online->offlinememory1 #online->offlinememory10 #online->offlinememory100 #online->offlinememory101 #online->offlinememory102
# online all hot-pluggable memory in offline state:Quoted 8 lines
#
offline->onlinememory1
#offline->onlinememory10
#offline->onlinememory100
#offline->onlinememory101
#offline->onlinememory102
# Test with memory notifier error injection
# ./mem-on-off-test.sh: line 267: echo: write error: Invalid argument #I can not reproduce the error according to the file 'reproduce'.
Line 267 is not runnable on my system. Is there something wrong here?
The code on my system like:
266 #
267 # Offline $ratio percent of hot-pluggable memory 268 #
269 echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error 270 for memory inhotpluggable_online_memory; do
271 if [ $((RANDOM % 100)) -lt $ratio ]; then
272offline_memory_expect_success$memory
&>/dev/null
273 fi
274 doneQuoted 3 lines
online_memory_expect_fail142: unexpected success #online_memory_expect_fail190: unexpected success # ./mem-on-off-test.sh: line 287: echo: write error: Invalid argument #The problem is similar with line 267.
Quoted 1 line
offline_memory_expect_fail107: unexpected success #
Quoted 8 lines
Quoted 1 line
It seems the error-inject not work.
Oh, I see that the version you run the test is based on commit
13023c33c962730a38d6b43995910c8805637a9a, and there is a bug onlib/notifier-error-inject.c.The commit of the fix patch is
c597d9054b13.Your test version has no the fix patch, So the test failed as expected
Thanks for the info. We tested on the fix patch and found that the issue is gone.
lib/notifier-error-inject: fix error when writing -errno to debugfs file
But seems this fix patch has not been merged to mainline yet. We run various selftests on mainline regularly, so we caught this issue and it is still there. Hope the fix will make it to mainline soon. Thanks.
--
Best Regards,
Yujie