Skip to contentSkip to conversation

sandbox: make function 'do_undefined' properly compiles for PowerPC

PATCH In review WHR 2 participants 2 messages Apr 30, 2024 – May 14, 2024

lore
Share & tools
lore

WHR

author
#0 lore raw

PATCH v3 1/1 sandbox: make function 'do_undefined' properly compiles for PowerPC

The 2 bytes 0xffff is too short for being a PowerPC instruction, resulting in an error similar to:
/tmp/ccW8yjie.s: Assembler messages:
/tmp/ccW8yjie.s: Error: unaligned opcodes detected in executable segment /tmp/ccW8yjie.s:223: Error: instruction address is not a multiple of 4 make[2]: *** [/tmp/ccyF4HIC.mk:17: /tmp/ccCKUFuF.ltrans5.ltrans.o] Error 1

---
v2:
Resubmit with diff content in plain text.
v3:
Reformat commit message body that was previously mangled by my email client.

 cmd/sandbox/exception.c | 4 ++++
 1 file changed, 4 insertions(+)
cmd/sandbox/exception.c +4 -0
index cfa153da26..f9c847d8ff 100644
@@ -19,7 +19,11 @@ static int do_sigsegv(struct cmd_tbl *cmdtp, int flag, int argc,
 static int do_undefined(struct cmd_tbl *cmdtp, int flag, int argc,
 			char *const argv[])
 {
+#ifdef __powerpc__
+	asm volatile (".long 0xffffffff\n");
+#else
 	asm volatile (".word 0xffff\n");
+#endif
 	return CMD_RET_FAILURE;
 }
 
#1 lore raw
Quoted 8 lines · WHR

The 2 bytes 0xffff is too short for being a PowerPC instruction, resulting in an error similar to:
/tmp/ccW8yjie.s: Assembler messages:
/tmp/ccW8yjie.s: Error: unaligned opcodes detected in executable segment /tmp/ccW8yjie.s:223: Error: instruction address is not a multiple of 4 make[2]: *** [/tmp/ccyF4HIC.mk:17: /tmp/ccCKUFuF.ltrans5.ltrans.o] Error 1

Applied to u-boot/next, thanks!

Signature · 1 line
Tom