Skip to contentSkip to conversation

tifm: fix the MemoryStick host fifo handling code

PATCH Alex Dubov 1 participant 1 message Mar 6, 2008

lore
Share & tools
lore

Alex Dubov

author
#0 lore raw
Quoted 8 lines · --- Andrew Morton

Review

Quoted 1 line · On Wed, 5 Mar 2008 03:02:22 +1100 [email protected] wrote:
(quoted diff) +1 -0
+			buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;

I am unable to convince myself that this driver always has local IRQs disabled when altering the KM_BIO_SRC_IRQ slot. Does it?

diff did rather bad job with this patch. The place in question looks like:

211: local_irq_save(flags);
212: buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
....
....
223: kunmap_atomic(buf - p_off, KM_BIO_SRC_IRQ); 224: local_irq_restore(flags);

      ____________________________________________________________________________________

Never miss a thing. Make Yahoo your home page.
http://www.yahoo.com/r/hs