Skip to contentSkip to conversation

Man sections: typo (No patch)

Openvpn-devel In review tincanteksup 2 participants 6 messages Dec 5, 2020 – Jan 20, 2021

lore
Share & tools
lore
#0 lore raw

Sorry for lack of patch.

doc/man-sections/renegotiation.rst +1 -1
index b817cfa8..c5484404 100644
@@ -35,7 +35,7 @@ separate ephemeral encryption key which is rotated at regular intervals.
   pseudo-uniform-randomized between ``min`` and ``max``.
 
   With the default value of :code:`3600` this results in an effective per
-  session value in the range of :code:`3240`..:code:`3600` seconds for
+  session value in the range of :code:`3240` .. :code:`3600` seconds for
   servers, or just 3600 for clients.
 
   When using dual-factor authentication, note that this default value may
#1 lore raw

Just FTR.

doc/man-sections/tls-options.rst +3 -3
index 5dd20013..28cf6f1e 100644
@@ -422,13 +422,13 @@ certificates and keys: https://github.com/OpenVPN/easy-rsa
   :code:`DEFAULT:!EXP:!LOW:!MEDIUM:!kDH:!kECDH:!DSS:!PSK:!SRP:!kRSA` when
   using OpenSSL.
 
-  The default for `--tls-ciphersuites` is to use the crypto library's
-  default.
-
 --tls-ciphersuites l
   Same as ``--tls-cipher`` but for TLS 1.3 and up. mbed TLS has no
   TLS 1.3 support yet and only the ``--tls-cipher`` setting is used.
 
+  The default for `--tls-ciphersuites` is to use the crypto library's
+  default.
+
 --tls-client
   Enable TLS and assume client role during TLS handshake.
 
#2 lore raw

Patchworks did not pick this up the way I expected.

#4 lore raw

PATCH 1/1 Man page sections corrections

In reply to tincanteksup
---
 doc/man-sections/renegotiation.rst | 2 +-
 doc/man-sections/tls-options.rst   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
doc/man-sections/renegotiation.rst +1 -1
index b817cfa8..c5484404 100644
@@ -35,7 +35,7 @@ separate ephemeral encryption key which is rotated at regular intervals.
   pseudo-uniform-randomized between ``min`` and ``max``.
 
   With the default value of :code:`3600` this results in an effective per
-  session value in the range of :code:`3240`..:code:`3600` seconds for
+  session value in the range of :code:`3240` .. :code:`3600` seconds for
   servers, or just 3600 for clients.
 
   When using dual-factor authentication, note that this default value may
doc/man-sections/tls-options.rst +3 -3
index 5dd20013..28cf6f1e 100644
@@ -422,13 +422,13 @@ certificates and keys: https://github.com/OpenVPN/easy-rsa
   :code:`DEFAULT:!EXP:!LOW:!MEDIUM:!kDH:!kECDH:!DSS:!PSK:!SRP:!kRSA` when
   using OpenSSL.
 
-  The default for `--tls-ciphersuites` is to use the crypto library's
-  default.
-
 --tls-ciphersuites l
   Same as ``--tls-cipher`` but for TLS 1.3 and up. mbed TLS has no
   TLS 1.3 support yet and only the ``--tls-cipher`` setting is used.
 
+  The default for `--tls-ciphersuites` is to use the crypto library's
+  default.
+
 --tls-client
   Enable TLS and assume client role during TLS handshake.
 
Signature · 1 line
2.25.1
#3 lore raw
In reply to tincanteksup

Hi,

Quoted 1 line · tincanteksup

Patchworks did not pick this up the way I expected.

"git send-email" adds more headers that helps patchwork differenciate between "it is a mail that might contain a diff" and "it's a submitted patch".

The last one looks good (and as #1563 in patchwork). Will take it from there.

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...
Acked-by on v1 1/1
#5 lore raw

[Openvpn-devel] [PATCH applied] Re: Man page sections corrections

In reply to Richard Bonhomme

Thanks. Well spotted.

Your patch has been applied to the master and release/2.5 branch.

commit 3b1ded3902b051b3c25f6e77da834ecd1b9f7eca (master) commit 9e2f1bf73aaf48a3a7baf0cda11ef1caf3c69baf (release/2.5)

Author: Richard Bonhomme
Date:   Tue Jan 19 21:56:17 2021 +0000
     Man page sections corrections

     Signed-off-by: Richard Bonhomme <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg21451.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering