Skip to contentSkip to conversation

x86: Further shrink ifdef sections in fault.c

PATCH Henry Nestler 2 participants 2 messages Apr 23, 2008 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 6 lines · Ingo Molnar

Review

Quoted 2 lines · Harvey Harrison
(quoted diff) +2 -0
+	if (!(address >= VMALLOC_START && address < VMALLOC_END))
+		return -1;

ah, this explains the weird chunk in your other patch.

Why this is not in x86_32?

Please see my other mail "x86: endless page faults in mount_block_root for Linux 2.6", with problem without this check.

Signature · 1 line
Henry N.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 8 lines · Henry Nestler
Quoted 6 lines · Ingo Molnar

Review

Quoted 2 lines · Harvey Harrison
(quoted diff) +2 -0
+	if (!(address >= VMALLOC_START && address < VMALLOC_END))
+		return -1;

ah, this explains the weird chunk in your other patch.

Quoted 5 lines

Why this is not in x86_32?

Please see my other mail "x86: endless page faults in mount_block_root for Linux 2.6"

Hmm, no idea why it wasn't in the 32-bit version. Looks like something fixed in the 64 bit versions but not 32-bit.

See:

commit 3b9ba4d5e23fcab24dd4d2e46dce11f5863869b4
commit f95190b28daa1bebf78ab5ec4129d01a223982c5

Cheers,

Harvey