Skip to contentSkip to conversation

drm-next build broken

DISCUSSION Tom St Denis 2 participants 3 messages Aug 28, 2018 2 messages not in the archive

lore
Share & tools
lore

Tom St Denis

author Reviewed-by Felix Kuehling
#0 lore raw

Hi Amber,

This commit:

commit 7c3a4287bfc05a26baa9d32d060feffe387b9b84 (HEAD -> amd-staging-drm-next, origin/amd-staging-drm-next, origin/HEAD)

Author: Amber Lin <[email protected]>
Date:   Thu Aug 23 10:52:34 2018 -0400

drm/amdgpu: Move KFD parameters to amdgpu

After merging KFD into amdgpu, move module parameters defined in KFD to amdgpu_drv.c, where other module parameters are declared.

v2: add kernel-doc comments

Change-Id I0f7a4cf601e5f0f3fd8a9d4703f6be00f1774788

Breaks the build:

DESCEND objtool

  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CC [M]  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:42:0:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_priv.h:645:22: error: field ‘mmu_notifier’ has incomplete type
  struct mmu_notifier mmu_notifier;
                      ^~~~~~~~~~~~

scripts/Makefile.build:317: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed make[4]: *** [drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o] Error 1 scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm/amd/amdgpu' failed make[3]: *** [drivers/gpu/drm/amd/amdgpu] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1034: recipe for target 'drivers' failed
make: *** [drivers] Error 2

Cheers,
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 9b377d54-07d4-5bb9-0669-4e4d4a50c9d5-5C7GfCeVMHo@public.gmane.org

Reviewed-by Felix Kuehling
#2 lore raw

Hi Tom,

May I ask which config I can use to see the issue? I used x86_64_defconfig before I submit the patch. I'll check immediately. Thanks for the notice.

Amber

-----Original Message-----
From: StDenis, Tom
Sent: Tuesday, August 28, 2018 9:19 AM
To: Lin, Amber <[email protected]>
Cc: [email protected]; Kuehling, Felix <[email protected]>
Subject: drm-next build broken

Hi Amber,

This commit:

commit 7c3a4287bfc05a26baa9d32d060feffe387b9b84 (HEAD -> amd-staging-drm-next, origin/amd-staging-drm-next, origin/HEAD)

Author: Amber Lin <[email protected]>
Date:   Thu Aug 23 10:52:34 2018 -0400

drm/amdgpu: Move KFD parameters to amdgpu

After merging KFD into amdgpu, move module parameters defined in KFD to amdgpu_drv.c, where other module parameters are declared.

v2: add kernel-doc comments

Change-Id I0f7a4cf601e5f0f3fd8a9d4703f6be00f1774788

Breaks the build:

DESCEND objtool

   CALL    scripts/checksyscalls.sh
   CHK     include/generated/compile.h
   CC [M]  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:42:0:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_priv.h:645:22: error: field ‘mmu_notifier’ has incomplete type
   struct mmu_notifier mmu_notifier;
                       ^~~~~~~~~~~~

scripts/Makefile.build:317: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed make[4]: *** [drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o] Error 1 scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm/amd/amdgpu' failed make[3]: *** [drivers/gpu/drm/amd/amdgpu] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1034: recipe for target 'drivers' failed
make: *** [drivers] Error 2

Cheers,
Tom
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BY2PR12MB00887B9A547930501A2048B0E10A0-K//h7OWB4q7c7AgKY82GyAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#4 lore raw

I use a defconfig + enable AMDGPU

$ grep AMDGPU .config
CONFIG_DRM_AMDGPU=m
CONFIG_DRM_AMDGPU_SI=y
CONFIG_DRM_AMDGPU_CIK=y
# CONFIG_DRM_AMDGPU_USERPTR is not set
# CONFIG_DRM_AMDGPU_GART_DEBUGFS is not set

Tom

Quoted 55 lines · Amber

Hi Tom,

May I ask which config I can use to see the issue? I used x86_64_defconfig before I submit the patch. I'll check immediately. Thanks for the notice.

Amber

-----Original Message-----
From: StDenis, Tom
Sent: Tuesday, August 28, 2018 9:19 AM
To: Lin, Amber <[email protected]>
Cc: [email protected]; Kuehling, Felix <[email protected]>
Subject: drm-next build broken

Hi Amber,

This commit:

commit 7c3a4287bfc05a26baa9d32d060feffe387b9b84 (HEAD -> amd-staging-drm-next, origin/amd-staging-drm-next, origin/HEAD)

Author: Amber Lin <[email protected]>
Date:   Thu Aug 23 10:52:34 2018 -0400

drm/amdgpu: Move KFD parameters to amdgpu

After merging KFD into amdgpu, move module parameters defined in KFD to amdgpu_drv.c, where other module parameters are declared.

v2: add kernel-doc comments

Change-Id I0f7a4cf601e5f0f3fd8a9d4703f6be00f1774788

Breaks the build:

DESCEND objtool
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:42:0:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_priv.h:645:22: error: field ‘mmu_notifier’ has incomplete type

    struct mmu_notifier mmu_notifier;
                        ^~~~~~~~~~~~

scripts/Makefile.build:317: recipe for target 'drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o' failed make[4]: *** [drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o] Error 1 scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm/amd/amdgpu' failed make[3]: *** [drivers/gpu/drm/amd/amdgpu] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1034: recipe for target 'drivers' failed
make: *** [drivers] Error 2

Quoted 3 lines

Cheers,
Tom

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx