Intel ICH - sound/pci/intel8x0.c
The joystick PCI ID table in intel8x0.c is not correct. Joysticks and MIDI ports are ISA devices and need be located by manual probing. This ID table needs to be removed. Joystick and MIDI ports do not have PCI IDs.
The PCI IDs in this table are for the ISA bridge chips, not the joystick port. These PC IDs should belong to the PCI bus driver. If I fix the PCI bus driver to claim these like it should, joystick support won't work any more.
static struct pci_device_id snd_intel8x0_joystick_ids[] = {
{ 0x8086, 0x2410, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* 82801AA */
{ 0x8086, 0x2420, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* 82901AB */
{ 0x8086, 0x2440, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* ICH2 */
{ 0x8086, 0x244c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* ICH2M */
{ 0x8086, 0x248c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* ICH3 */
// { 0x8086, 0x7195, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* 440MX */
// { 0x1039, 0x7012, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* SI7012 */
{ 0x10de, 0x01b2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* NFORCE */
{ 0x10de, 0x006b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* NFORCE2 */
{ 0x10de, 0x00db, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* NFORCE3 */
{ 0, }
};2410 82801AA ISA Bridge (LPC)
2420 82801AB ISA Bridge (LPC)
2440 82801BA ISA Bridge (LPC)
244c 82801BAM ISA Bridge (LPC)
248c 82801CAM ISA Bridge (LPC)
01b2 nForce ISA Bridge
Signature · 2 lines
Jon Smirl [email protected]
Quoted 4 lines · Jon Smirl
The joystick PCI ID table in
intel8x0.cis not correct. Joysticks and MIDI ports are ISA devices and need be located by manual probing. This ID table needs to be removed. Joystick and MIDI ports do not have PCI IDs.
It isn't that simple. The LPC bridge also contains the controls for the joystick ports. You also need them for hotplug handling of the bridge should someone stick one in a laptop docking station. The ID table also ensures the driver is loaded. It's probably true that it will need splitting up a bit if another driver also needs ownership of the LPC bridge but for now that hasn't happened.
Also a lot of other vendors Midi and joystick ports do have PCI ids.
Alan
Ok, I can change so I don't have to take ownership of the bridge from the PCI driver so there isn't a conflict. "Intel ICH Joystick" is a deceptive name for this driver. It should be named something like "LPC bridge" since there are other things on that device than the joystick. Why does just the joystick need a special driver and nothing else on that bridge needs one? Wouldn't PS/2, serial, parallel, etc all have this problem?
"Intel ICH" is also a bad driver name. I'd prefer something like "snd_intel8x0" since that is what the module is named.
Quoted 1 line · Alan Cox
Also a lot of other vendors Midi and joystick ports do have PCI ids.
I was thinking about this from the probing side. You can't count on midi and joystick ports having PCI IDs so you have to manually probe. But I also see how a card with a PCI ID could have these ports on it and also include logic for turning them off and on.
Quoted 17 lines · Alan Cox
Quoted 4 lines · Jon Smirl
The joystick PCI ID table in
intel8x0.cis not correct. Joysticks and MIDI ports are ISA devices and need be located by manual probing. This ID table needs to be removed. Joystick and MIDI ports do not have PCI IDs.It isn't that simple. The LPC bridge also contains the controls for the joystick ports. You also need them for hotplug handling of the bridge should someone stick one in a laptop docking station. The ID table also ensures the driver is loaded. It's probably true that it will need splitting up a bit if another driver also needs ownership of the LPC bridge but for now that hasn't happened.
Also a lot of other vendors Midi and joystick ports do have PCI ids.
Alan
Signature · 2 lines
Jon Smirl [email protected]
At Sat, 4 Sep 2004 22:43:01 -0400,
Quoted 5 lines · Jon Smirl
The joystick PCI ID table in
intel8x0.cis not correct. Joysticks and MIDI ports are ISA devices and need be located by manual probing. This ID table needs to be removed. Joystick and MIDI ports do not have PCI IDs.
They were already removed from the latest ALSA cvs codes. So, this should be fixed in the next ALSA update patchset.
Takashi