Skip to contentSkip to conversation

ide and ROMs

DISCUSSION Jon Smirl 2 participants 2 messages Feb 2, 2005 – Feb 3, 2005

lore
Share & tools
lore

Jon Smirl

author
#0 lore raw

Since it looks like ide is being worked on, can you convert ide to use the PCI ROM access calls in drivers/pci/rom.c instead of directly manipulating PCI config space? The new ROM calls work on all architectures.

These are the places that need to be fix:
[jonsmirl@jonsmirl ide]$ grep -r PCI_ROM_ADDRESS_ENABLE *
pci/aec62xx.c: pci_write_config_dword(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/cmd64x.c: pci_write_config_byte(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE); pci/hpt34x.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/hpt366.c: dev->resource[PCI_ROM_RESOURCE].start
| PCI_ROM_ADDRESS_ENABLE);
pci/pdc202xx_new.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE); pci/pdc202xx_old.c:
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE); [jonsmirl@jonsmirl ide]$

Signature · 2 lines
Jon Smirl
[email protected]
#1 lore raw
Quoted 11 lines · Jon Smirl

Since it looks like ide is being worked on, can you convert ide to use the PCI ROM access calls in drivers/pci/rom.c instead of directly manipulating PCI config space? The new ROM calls work on all architectures.

These are the places that need to be fix:
[jonsmirl@jonsmirl ide]$ grep -r PCI_ROM_ADDRESS_ENABLE *
pci/aec62xx.c: pci_write_config_dword(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/cmd64x.c: pci_write_config_byte(dev, PCI_ROM_ADDRESS,
dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);

Quoted 6 lines
pci/hpt34x.c:                          dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/hpt366.c:                   dev->resource[PCI_ROM_RESOURCE].start
| PCI_ROM_ADDRESS_ENABLE);
pci/pdc202xx_new.c:                    dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
pci/pdc202xx_old.c:                    dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);

[jonsmirl@jonsmirl ide]$

Sure, I'll look at it.

Signature · 1 line
tejun