Skip to contentSkip to conversation

Fix "configure: error: gbm requires --enable-dri"

PATCH In review Jens Rehsack 2 participants 2 messages Oct 1, 2015 – Oct 2, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/9 Fix "configure: error: gbm requires --enable-dri"

---
 meta/recipes-graphics/mesa/mesa.inc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/recipes-graphics/mesa/mesa.inc +1 -3
index af7a2c4..13a8b9d 100644
@@ -37,11 +37,9 @@ PACKAGECONFIG[wayland] = ",,wayland"
 DRIDRIVERS = "swrast"
 DRIDRIVERS_append_x86 = ",radeon,r200,nouveau,i965,i915"
 DRIDRIVERS_append_x86-64 = ",radeon,r200,nouveau,i965,i915"
-PACKAGECONFIG[dri] = "--enable-dri --with-dri-drivers=${DRIDRIVERS}, --disable-dri, dri2proto libdrm"
+PACKAGECONFIG[dri] = "--enable-dri --with-dri-drivers=${DRIDRIVERS} --enable-gbm, --disable-dri, dri2proto libdrm"
 PACKAGECONFIG[dri3] = "--enable-dri3, --disable-dri3, dri3proto presentproto libxshmfence"
 
-EXTRA_OECONF += "--enable-gbm"
-
 PACKAGECONFIG[gles] = "--enable-gles1 --enable-gles2, --disable-gles1 --disable-gles2"
 
 EGL_PLATFORMS  = "drm"
Signature · 4 lines
1.9.1

-- 
Jens Rehsack - [email protected]
#1 lore raw
Quoted 23 lines · Jens Rehsack
---
 meta/recipes-graphics/mesa/mesa.inc | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/recipes-graphics/mesa/mesa.inc +1 -3
index af7a2c4..13a8b9d 100644
@@ -37,11 +37,9 @@ PACKAGECONFIG[wayland] = ",,wayland"
 DRIDRIVERS = "swrast"
 DRIDRIVERS_append_x86 = ",radeon,r200,nouveau,i965,i915"
 DRIDRIVERS_append_x86-64 = ",radeon,r200,nouveau,i965,i915"
-PACKAGECONFIG[dri] = "--enable-dri --with-dri-drivers=${DRIDRIVERS},
--disable-dri, dri2proto libdrm"
+PACKAGECONFIG[dri] = "--enable-dri --with-dri-drivers=${DRIDRIVERS}
--enable-gbm, --disable-dri, dri2proto libdrm"
 PACKAGECONFIG[dri3] = "--enable-dri3, --disable-dri3, dri3proto

presentproto libxshmfence"

meta/recipes-graphics/mesa/mesa.inc PACKAGECONFIG[wayland] = ",,wayland" · line 44

Quoted 2 lines
meta/recipes-graphics/mesa/mesa.inc +0 -2
-EXTRA_OECONF += "--enable-gbm"
-

Martins generic comments apply but on top of that: Please add a short explanation. I would have expected gbm to get enabled from PACKAGECONFIG[egl] but possibly I don't understand the whole context: are there EGL users who do not want GBM?. Also, if you use --enable-gdm conditionally, you should --disable-gbm in the other case: otherwise mesa autodetects and that might be non-deterministic (now or in future).

Jussi

Quoted 16 lines

PACKAGECONFIG[gles] = "--enable-gles1 --enable-gles2, --disable-gles1
--disable-gles2"

EGL_PLATFORMS = "drm"
--
1.9.1

--
Jens Rehsack - [email protected]

--
_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky